From a0dfa3fddce4608cedf2033ee4482693b409a7dc Mon Sep 17 00:00:00 2001
From: James King <james@jamesking56.uk>
Date: Tue, 9 Oct 2018 04:05:20 +0100
Subject: [PATCH] fix(gitlab): issues API is `description` not `body` (#2620)
Fixes a crash with GitLab due to the API Issue body being called `description` and not `body`:
https://docs.gitlab.com/ee/api/issues.html#single-issue
Closes #2619
---
lib/platform/gitlab/index.js | 4 ++--
test/platform/gitlab/index.spec.js | 6 +++---
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/lib/platform/gitlab/index.js b/lib/platform/gitlab/index.js
index 9eda529f27..2fdea58ac7 100644
--- a/lib/platform/gitlab/index.js
+++ b/lib/platform/gitlab/index.js
@@ -425,7 +425,7 @@ async function findIssue(title) {
}
const issueBody = (await get(
`projects/${config.repository}/issues/${issue.iid}`
- )).body.body;
+ )).body.description;
return {
number: issue.iid,
body: issueBody,
@@ -444,7 +444,7 @@ async function ensureIssue(title, body) {
if (issue) {
const issueBody = (await get(
`projects/${config.repository}/issues/${issue.iid}`
- )).body.body;
+ )).body.description;
if (issueBody !== body) {
logger.debug('Updating issue body');
await get.put(`projects/${config.repository}/issues/${issue.iid}`, {
diff --git a/test/platform/gitlab/index.spec.js b/test/platform/gitlab/index.spec.js
index fd3960d2f5..0e7f7ba803 100644
--- a/test/platform/gitlab/index.spec.js
+++ b/test/platform/gitlab/index.spec.js
@@ -591,7 +591,7 @@ describe('platform/gitlab', () => {
},
],
});
- get.mockReturnValueOnce({ body: { body: 'new-content' } });
+ get.mockReturnValueOnce({ body: { description: 'new-content' } });
const res = await gitlab.findIssue('title-2');
expect(res).not.toBeNull();
});
@@ -626,7 +626,7 @@ describe('platform/gitlab', () => {
},
],
});
- get.mockReturnValueOnce({ body: { body: 'new-content' } });
+ get.mockReturnValueOnce({ body: { description: 'new-content' } });
const res = await gitlab.ensureIssue('title-2', 'newer-content');
expect(res).toEqual('updated');
});
@@ -643,7 +643,7 @@ describe('platform/gitlab', () => {
},
],
});
- get.mockReturnValueOnce({ body: { body: 'newer-content' } });
+ get.mockReturnValueOnce({ body: { description: 'newer-content' } });
const res = await gitlab.ensureIssue('title-2', 'newer-content');
expect(res).toBe(null);
});
--
GitLab