From a3b4dd4f96b1c68b106f2a62abf2edda400ee7a2 Mon Sep 17 00:00:00 2001
From: Rhys Arkins <rhys@arkins.net>
Date: Fri, 20 Jul 2018 10:25:44 +0200
Subject: [PATCH] fix(docker): return valid only if valid version
---
lib/versioning/docker/index.js | 3 +++
test/versioning/docker.spec.js | 10 ++++++++++
2 files changed, 13 insertions(+)
create mode 100644 test/versioning/docker.spec.js
diff --git a/lib/versioning/docker/index.js b/lib/versioning/docker/index.js
index 9017641c68..f0a3866de3 100644
--- a/lib/versioning/docker/index.js
+++ b/lib/versioning/docker/index.js
@@ -1,5 +1,8 @@
const semver = require('../semver');
+const isValid = input => semver.isVersion(input);
+
module.exports = {
...semver,
+ isValid,
};
diff --git a/test/versioning/docker.spec.js b/test/versioning/docker.spec.js
new file mode 100644
index 0000000000..215d2f85c8
--- /dev/null
+++ b/test/versioning/docker.spec.js
@@ -0,0 +1,10 @@
+const docker = require('../../lib/versioning')('docker');
+
+describe('docker.isValid(input)', () => {
+ it('should return null for short version', () => {
+ expect(!!docker.isValid('3.7')).toBe(false);
+ });
+ it('should support semver', () => {
+ expect(!!docker.isValid('1.2.3')).toBe(true);
+ });
+});
--
GitLab