From a41aefc23d5e2ae5cb4217a5897faa039461ba9e Mon Sep 17 00:00:00 2001
From: Misha Kaletsky <15040698+mmkal@users.noreply.github.com>
Date: Mon, 12 Oct 2020 01:32:14 -0400
Subject: [PATCH] feat: find release notes for rush repos (#7445)
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
---
.../__snapshots__/release-notes.spec.ts.snap | 26 +++++++++++++++++++
.../pr/changelog/release-notes.spec.ts | 2 +-
lib/workers/pr/changelog/release-notes.ts | 3 ++-
3 files changed, 29 insertions(+), 2 deletions(-)
diff --git a/lib/workers/pr/changelog/__snapshots__/release-notes.spec.ts.snap b/lib/workers/pr/changelog/__snapshots__/release-notes.spec.ts.snap
index 340190a1ad..5cb9c77426 100644
--- a/lib/workers/pr/changelog/__snapshots__/release-notes.spec.ts.snap
+++ b/lib/workers/pr/changelog/__snapshots__/release-notes.spec.ts.snap
@@ -182,6 +182,32 @@ Array [
]
`;
+exports[`workers/pr/changelog/release-notes getReleaseNotes() gets release notes with body 7`] = `
+Object {
+ "body": "some body [#123](https://github.com/some/other-repository/issues/123), [#124](https://github.com/some/yet-other-repository/issues/124)
+",
+ "id": undefined,
+ "name": undefined,
+ "tag": "other_v1.0.1",
+ "url": "https://github.com/some/other-repository/releases/other_v1.0.1",
+}
+`;
+
+exports[`workers/pr/changelog/release-notes getReleaseNotes() gets release notes with body 8`] = `
+Array [
+ Object {
+ "headers": Object {
+ "accept": "application/vnd.github.v3+json",
+ "accept-encoding": "gzip, deflate",
+ "host": "api.github.com",
+ "user-agent": "https://github.com/renovatebot/renovate",
+ },
+ "method": "GET",
+ "url": "https://api.github.com/repos/some/other-repository/releases?per_page=100",
+ },
+]
+`;
+
exports[`workers/pr/changelog/release-notes getReleaseNotes() gets release notes with body from gitlab repo 1`] = `null`;
exports[`workers/pr/changelog/release-notes getReleaseNotes() gets release notes with body from gitlab repo 2`] = `
diff --git a/lib/workers/pr/changelog/release-notes.spec.ts b/lib/workers/pr/changelog/release-notes.spec.ts
index ef1b7320e0..0db5dbd18d 100644
--- a/lib/workers/pr/changelog/release-notes.spec.ts
+++ b/lib/workers/pr/changelog/release-notes.spec.ts
@@ -146,7 +146,7 @@ describe(getName(__filename), () => {
expect(res).toBeNull();
expect(httpMock.getTrace()).toMatchSnapshot();
});
- it.each([[''], ['v'], ['other-']])(
+ it.each([[''], ['v'], ['other-'], ['other_v']])(
'gets release notes with body',
async (prefix) => {
httpMock
diff --git a/lib/workers/pr/changelog/release-notes.ts b/lib/workers/pr/changelog/release-notes.ts
index 50228c5ca0..aac17409ca 100644
--- a/lib/workers/pr/changelog/release-notes.ts
+++ b/lib/workers/pr/changelog/release-notes.ts
@@ -96,7 +96,8 @@ export async function getReleaseNotes(
if (
release.tag === version ||
release.tag === `v${version}` ||
- release.tag === `${depName}-${version}`
+ release.tag === `${depName}-${version}` ||
+ release.tag === `${depName}_v${version}`
) {
releaseNotes = release;
releaseNotes.url = baseUrl.includes('gitlab')
--
GitLab