From a445a663360c92013d14f61f9f4b928bfdfb699f Mon Sep 17 00:00:00 2001
From: Sebastian Poxhofer <secustor@users.noreply.github.com>
Date: Thu, 17 Jun 2021 10:51:30 +0200
Subject: [PATCH] feat: remove defaulting to semver versioning (#10431)
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
---
lib/config/definitions.ts | 2 --
lib/versioning/index.ts | 2 +-
lib/workers/branch/index.spec.ts | 3 ---
3 files changed, 1 insertion(+), 6 deletions(-)
diff --git a/lib/config/definitions.ts b/lib/config/definitions.ts
index 11cfde45e6..daf81de7c8 100644
--- a/lib/config/definitions.ts
+++ b/lib/config/definitions.ts
@@ -4,7 +4,6 @@ import { getPlatformList } from '../platform';
import { getVersioningList } from '../versioning';
import * as dockerVersioning from '../versioning/docker';
import * as pep440Versioning from '../versioning/pep440';
-import * as semverVersioning from '../versioning/semver';
import type { RenovateOptions } from './types';
const options: RenovateOptions[] = [
@@ -710,7 +709,6 @@ const options: RenovateOptions[] = [
description: 'Versioning to use for filtering and comparisons.',
type: 'string',
allowedValues: getVersioningList(),
- default: semverVersioning.id,
cli: false,
env: false,
},
diff --git a/lib/versioning/index.ts b/lib/versioning/index.ts
index da12a3de64..a192f83538 100644
--- a/lib/versioning/index.ts
+++ b/lib/versioning/index.ts
@@ -16,7 +16,7 @@ export const getVersionings = (): Map<
export function get(versioning: string): VersioningApi {
if (!versioning) {
- logger.debug('Missing versioning');
+ logger.trace('Missing versioning, using semver as fallback.');
return versionings.get('semver') as VersioningApi;
}
let versioningName: string;
diff --git a/lib/workers/branch/index.spec.ts b/lib/workers/branch/index.spec.ts
index f284452a1a..ac74e0efe3 100644
--- a/lib/workers/branch/index.spec.ts
+++ b/lib/workers/branch/index.spec.ts
@@ -846,9 +846,6 @@ describe(getName(), () => {
});
expect(result).toMatchSnapshot();
- expect(exec.exec).toHaveBeenCalledWith('echo semver', {
- cwd: '/localDir',
- });
const errorMessage = expect.stringContaining(
"Post-upgrade command 'disallowed task' does not match allowed pattern '^echo {{{versioning}}}$'"
);
--
GitLab