From a7d1bd4b0850118f7b3ea9d3411e52ca65aae07d Mon Sep 17 00:00:00 2001
From: Jamie Magee <JamieMagee@users.noreply.github.com>
Date: Mon, 17 Feb 2020 16:20:21 +0100
Subject: [PATCH] feat: add $schema to default onboarding configuration (#5496)
fixes #5427
---
lib/config/definitions.ts | 2 +-
.../onboarding/branch/__snapshots__/index.spec.ts.snap | 8 ++++++++
test/workers/repository/onboarding/branch/index.spec.ts | 8 ++++++++
3 files changed, 17 insertions(+), 1 deletion(-)
diff --git a/lib/config/definitions.ts b/lib/config/definitions.ts
index ec45d23f9c..1fd1401c97 100644
--- a/lib/config/definitions.ts
+++ b/lib/config/definitions.ts
@@ -305,7 +305,7 @@ const options: RenovateOptions[] = [
description: 'Configuration to use in onboarding PRs',
stage: 'repository',
type: 'object',
- default: {},
+ default: { $schema: 'https://docs.renovatebot.com/renovate-schema.json' },
admin: true,
mergeable: true,
},
diff --git a/test/workers/repository/onboarding/branch/__snapshots__/index.spec.ts.snap b/test/workers/repository/onboarding/branch/__snapshots__/index.spec.ts.snap
index c7ea67e145..abf19bd7c5 100644
--- a/test/workers/repository/onboarding/branch/__snapshots__/index.spec.ts.snap
+++ b/test/workers/repository/onboarding/branch/__snapshots__/index.spec.ts.snap
@@ -2,6 +2,7 @@
exports[`workers/repository/onboarding/branch checkOnboardingBranch creates onboarding branch with greenkeeper migration 1`] = `
"{
+ \\"$schema\\": \\"https://docs.renovatebot.com/renovate-schema.json\\",
\\"statusCheckVerify\\": true,
\\"labels\\": [
\\"renovate\\"
@@ -14,3 +15,10 @@ exports[`workers/repository/onboarding/branch checkOnboardingBranch creates onbo
}
"
`;
+
+exports[`workers/repository/onboarding/branch checkOnboardingBranch has default onboarding config 1`] = `
+"{
+ \\"$schema\\": \\"https://docs.renovatebot.com/renovate-schema.json\\"
+}
+"
+`;
diff --git a/test/workers/repository/onboarding/branch/index.spec.ts b/test/workers/repository/onboarding/branch/index.spec.ts
index cb7073bc41..9e7e5eae43 100644
--- a/test/workers/repository/onboarding/branch/index.spec.ts
+++ b/test/workers/repository/onboarding/branch/index.spec.ts
@@ -20,6 +20,14 @@ describe('workers/repository/onboarding/branch', () => {
config.isFork = true;
await expect(checkOnboardingBranch(config)).rejects.toThrow();
});
+ it('has default onboarding config', async () => {
+ platform.getFileList.mockResolvedValue(['package.json']);
+ platform.getFile.mockResolvedValue('{}');
+ await checkOnboardingBranch(config);
+ expect(
+ platform.commitFilesToBranch.mock.calls[0][0].files[0].contents
+ ).toMatchSnapshot();
+ });
it('handles skipped onboarding combined with requireConfig = false', async () => {
config.requireConfig = false;
config.onboarding = false;
--
GitLab