From a7e11152374fe2ae17fba86aaa384dad4bcbe4c0 Mon Sep 17 00:00:00 2001
From: Rhys Arkins <rhys@arkins.net>
Date: Thu, 6 Jun 2019 17:01:26 +0200
Subject: [PATCH] fix: redact private header
---
lib/logger/err-serializer.js | 17 +++++++++++------
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/lib/logger/err-serializer.js b/lib/logger/err-serializer.js
index 4c4d64d18c..b18605afaf 100644
--- a/lib/logger/err-serializer.js
+++ b/lib/logger/err-serializer.js
@@ -17,12 +17,17 @@ function errSerializer(err) {
if (err.stack) {
response.stack = err.stack;
}
- if (
- err.gotOptions &&
- err.gotOptions.headers &&
- err.gotOptions.headers.authorization
- ) {
- response.gotOptions.headers.authorization = '** redacted **';
+ if (err.gotOptions && err.gotOptions.headers) {
+ const redactedHeaders = [
+ 'authorization',
+ 'private-header',
+ 'Private-header',
+ ];
+ redactedHeaders.forEach(header => {
+ if (response.gotOptions.headers[header]) {
+ response.gotOptions.headers[header] = '** redacted **';
+ }
+ });
}
const redactedFields = ['message', 'stack', 'stdout', 'stderr'];
for (const field of redactedFields) {
--
GitLab