From a8da588f1349b2dee88c40e600d0633728a5a839 Mon Sep 17 00:00:00 2001
From: Rhys Arkins <rhys@keylocation.sg>
Date: Wed, 28 Jun 2017 12:45:18 +0200
Subject: [PATCH] =?UTF-8?q?Don=E2=80=99t=20warn=20if=20currentVersion=20is?=
=?UTF-8?q?=20a=20known=20tag?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Closes #333
---
lib/workers/package/versions.js | 7 ++++++-
test/workers/package/versions.spec.js | 4 ++++
2 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/lib/workers/package/versions.js b/lib/workers/package/versions.js
index 56aab78592..afe075b015 100644
--- a/lib/workers/package/versions.js
+++ b/lib/workers/package/versions.js
@@ -15,7 +15,12 @@ module.exports = {
function determineUpgrades(npmDep, config) {
const currentVersion = config.currentVersion;
if (!isValidVersion(currentVersion)) {
- logger.warn(`${npmDep.name} currentVersion ${currentVersion} is invalid`);
+ const knownTags = ['latest', 'next', 'future', 'alpha', 'beta'];
+ if (knownTags.indexOf(currentVersion) === -1) {
+ logger.warn(`${npmDep.name} currentVersion ${currentVersion} is invalid`);
+ } else {
+ logger.debug(`Skipping ${npmDep.name} with tag ${currentVersion}`);
+ }
return [];
}
const versions = npmDep.versions;
diff --git a/test/workers/package/versions.spec.js b/test/workers/package/versions.spec.js
index 29964bcfe5..ff698b4a51 100644
--- a/test/workers/package/versions.spec.js
+++ b/test/workers/package/versions.spec.js
@@ -14,6 +14,10 @@ describe('workers/package/versions', () => {
config.currentVersion = 'invalid';
versions.determineUpgrades(qJson, config).should.have.length(0);
});
+ it('return empty if using a known tag', () => {
+ config.currentVersion = 'next';
+ versions.determineUpgrades(qJson, config).should.have.length(0);
+ });
it('return empty if null versions', () => {
config.currentVersion = '1.0.0';
const testDep = {
--
GitLab