From c2f18e47d498abfcccb91071c038f2bca507d958 Mon Sep 17 00:00:00 2001
From: Rhys Arkins <rhys@arkins.net>
Date: Tue, 22 Jan 2019 05:55:09 +0100
Subject: [PATCH] fix(ruby): datasource throw if empty
---
lib/datasource/ruby-version/index.js | 2 +-
test/datasource/ruby-version.spec.js | 10 ++++++++--
2 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/lib/datasource/ruby-version/index.js b/lib/datasource/ruby-version/index.js
index 61a00b4839..69226616f1 100644
--- a/lib/datasource/ruby-version/index.js
+++ b/lib/datasource/ruby-version/index.js
@@ -39,6 +39,6 @@ async function getPkgReleases() {
throw new Error('registry-failure');
}
logger.warn({ err }, 'Ruby release lookup failure: Unknown error');
- return null;
+ throw new Error('registry-failure');
}
}
diff --git a/test/datasource/ruby-version.spec.js b/test/datasource/ruby-version.spec.js
index c6709d68ca..da32d03f95 100644
--- a/test/datasource/ruby-version.spec.js
+++ b/test/datasource/ruby-version.spec.js
@@ -18,9 +18,15 @@ describe('datasource/gradle', () => {
const res = await getPkgReleases();
expect(res).toMatchSnapshot();
});
- it('returns null for empty result', async () => {
+ it('throws for empty result', async () => {
got.mockReturnValueOnce({ body: {} });
- expect(await getPkgReleases()).toBeNull();
+ let e;
+ try {
+ await getPkgReleases();
+ } catch (err) {
+ e = err;
+ }
+ expect(e).toBeDefined();
});
it('throws for 404', async () => {
--
GitLab