From c966eb1c9ce564f276aa0eeeebf26e1e9c1e665c Mon Sep 17 00:00:00 2001
From: Sergei Zharinov <zharinov@users.noreply.github.com>
Date: Mon, 7 Feb 2022 08:59:22 +0300
Subject: [PATCH] refactor(versioning): Enable strict null checks (#14053)
---
lib/versioning/index.ts | 13 ++++---------
tsconfig.strict.json | 5 -----
2 files changed, 4 insertions(+), 14 deletions(-)
diff --git a/lib/versioning/index.ts b/lib/versioning/index.ts
index 0bdc0e7d6c..a6d2e5a966 100644
--- a/lib/versioning/index.ts
+++ b/lib/versioning/index.ts
@@ -19,16 +19,11 @@ export function get(versioning: string): VersioningApi {
logger.trace('Missing versioning, using semver as fallback.');
return versionings.get('semver') as VersioningApi;
}
- let versioningName: string;
- let versioningConfig: string;
+ const [versioningName, ...versioningRest] = versioning.split(':');
+ const versioningConfig = versioningRest.length
+ ? versioningRest.join(':')
+ : undefined;
- if (versioning.includes(':')) {
- const versionSplit = versioning.split(':');
- versioningName = versionSplit.shift();
- versioningConfig = versionSplit.join(':');
- } else {
- versioningName = versioning;
- }
const theVersioning = versionings.get(versioningName);
if (!theVersioning) {
logger.info({ versioning }, 'Unknown versioning - defaulting to semver');
diff --git a/tsconfig.strict.json b/tsconfig.strict.json
index 4c3b48601f..298645ceb8 100644
--- a/tsconfig.strict.json
+++ b/tsconfig.strict.json
@@ -381,11 +381,6 @@
"lib/util/ignore.ts",
"lib/util/merge-confidence/index.ts",
"lib/util/package-rules.ts",
- "lib/versioning/api.ts",
- "lib/versioning/common.ts",
- "lib/versioning/helm/index.ts",
- "lib/versioning/index.ts",
- "lib/versioning/types.ts",
"lib/workers/branch/artifacts.ts",
"lib/workers/branch/auto-replace.ts",
"lib/workers/branch/automerge.ts",
--
GitLab