From c9f2d387fa8de25f17fad8cfe1a89d4f976efecb Mon Sep 17 00:00:00 2001
From: Rhys Arkins <rhys@arkins.net>
Date: Tue, 20 Mar 2018 15:51:37 +0100
Subject: [PATCH] fix: use github tags not releases to determine node versions
Closes #1691
---
lib/manager/_helpers/node/package.js | 4 ++--
test/manager/_helpers/node/package.spec.js | 8 ++++----
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/lib/manager/_helpers/node/package.js b/lib/manager/_helpers/node/package.js
index 84960e757f..2ba2ab57de 100644
--- a/lib/manager/_helpers/node/package.js
+++ b/lib/manager/_helpers/node/package.js
@@ -1,5 +1,5 @@
const semver = require('semver');
-const { getRepoReleases, semverSort } = require('../../../datasource/github');
+const { getRepoTags, semverSort } = require('../../../datasource/github');
async function getPackageUpdates(config) {
logger.debug('getPackageUpdates()');
@@ -20,7 +20,7 @@ async function getPackageUpdates(config) {
token = process.env.GITHUB_TOKEN;
process.env.GITHUB_TOKEN = process.env.GITHUB_COM_TOKEN;
}
- const newReleases = (await getRepoReleases('nodejs/node'))
+ const newReleases = (await getRepoTags('nodejs/node'))
.map(release => release.replace(/^v/, ''))
.filter(release => semver.major(currentVersion) === semver.major(release))
.filter(release => semver.gt(release, currentVersion))
diff --git a/test/manager/_helpers/node/package.spec.js b/test/manager/_helpers/node/package.spec.js
index f24a89b2af..3937145c1a 100644
--- a/test/manager/_helpers/node/package.spec.js
+++ b/test/manager/_helpers/node/package.spec.js
@@ -1,5 +1,5 @@
const nodeManager = require('../../../../lib/manager/_helpers/node/package');
-const { getRepoReleases } = require('../../../../lib/datasource/github');
+const { getRepoTags } = require('../../../../lib/datasource/github');
jest.mock('../../../../lib/datasource/github');
@@ -17,20 +17,20 @@ describe('manager/npm/engines', () => {
});
it('returns empty', async () => {
config.currentVersion = '8.9.0';
- getRepoReleases.mockReturnValueOnce([]);
+ getRepoTags.mockReturnValueOnce([]);
const res = await nodeManager.getPackageUpdates(config);
expect(res).toEqual([]);
});
it('filters v', async () => {
config.currentVersion = '8.9.0';
- getRepoReleases.mockReturnValueOnce(['v8.0.0', 'v8.9.1']);
+ getRepoTags.mockReturnValueOnce(['v8.0.0', 'v8.9.1']);
const res = await nodeManager.getPackageUpdates(config);
expect(res).toHaveLength(1);
expect(res[0].newVersion).toEqual('8.9.1');
});
it('skips major versions', async () => {
config.currentVersion = '8.9.0';
- getRepoReleases.mockReturnValueOnce(['v9.4.0']);
+ getRepoTags.mockReturnValueOnce(['v9.4.0']);
const res = await nodeManager.getPackageUpdates(config);
expect(res).toHaveLength(0);
});
--
GitLab