From cb53e18de807c07e3f76a11cf09e209d98a13b24 Mon Sep 17 00:00:00 2001
From: Gabriel-Ladzaretti
<97394622+Gabriel-Ladzaretti@users.noreply.github.com>
Date: Thu, 25 Aug 2022 09:43:13 +0300
Subject: [PATCH] chore(util/exec): remove unneeded renaming related TODOs
(#17399)
---
lib/util/exec/common.ts | 3 +--
lib/util/exec/types.ts | 3 ---
test/exec-util.ts | 5 -----
3 files changed, 1 insertion(+), 10 deletions(-)
diff --git a/lib/util/exec/common.ts b/lib/util/exec/common.ts
index 5287586355..3b27c5127a 100644
--- a/lib/util/exec/common.ts
+++ b/lib/util/exec/common.ts
@@ -145,8 +145,7 @@ function kill(cp: ChildProcess, signal: NodeJS.Signals): boolean {
}
}
-// TODO: rename #16653
export const rawExec: (
cmd: string,
opts: RawExecOptions
-) => Promise<ExecResult> = exec; // TODO: rename #16653
+) => Promise<ExecResult> = exec;
diff --git a/lib/util/exec/types.ts b/lib/util/exec/types.ts
index 9f8244bf7f..2cc555e0bf 100644
--- a/lib/util/exec/types.ts
+++ b/lib/util/exec/types.ts
@@ -27,7 +27,6 @@ export interface DockerOptions {
cwd?: Opt<string>;
}
-// TODO: rename #16653
export interface RawExecOptions extends ChildProcessSpawnOptions {
// TODO: to be removed in #16655
/**
@@ -38,7 +37,6 @@ export interface RawExecOptions extends ChildProcessSpawnOptions {
cwd?: string;
}
-// TODO: rename #16653
export interface ExecResult {
stdout: string;
stderr: string;
@@ -46,7 +44,6 @@ export interface ExecResult {
export type ExtraEnv<T = unknown> = Record<string, T>;
-// TODO: rename #16653
export interface ExecOptions {
cwd?: string;
cwdFile?: string;
diff --git a/test/exec-util.ts b/test/exec-util.ts
index 35dc99bfbc..ff9a2269eb 100644
--- a/test/exec-util.ts
+++ b/test/exec-util.ts
@@ -8,7 +8,6 @@ import { mockedFunction } from './util';
jest.mock('../lib/util/exec/common');
-// TODO: rename #16653
export type ExecResult = { stdout: string; stderr: string } | Error;
export const exec = mockedFunction(_exec);
@@ -18,10 +17,8 @@ export interface ExecSnapshot {
options?: RawExecOptions | null | undefined;
}
-// TODO: rename #16653
export type ExecSnapshots = ExecSnapshot[];
-// TODO: rename #16653
function execSnapshot(cmd: string, options?: RawExecOptions): ExecSnapshot {
const snapshot = {
cmd,
@@ -42,7 +39,6 @@ function execSnapshot(cmd: string, options?: RawExecOptions): ExecSnapshot {
const defaultExecResult = { stdout: '', stderr: '' };
-// TODO: rename #16653
export function mockExecAll(
execResult: ExecResult = defaultExecResult
): ExecSnapshots {
@@ -57,7 +53,6 @@ export function mockExecAll(
return snapshots;
}
-// TODO: rename #16653
export function mockExecSequence(execResults: ExecResult[]): ExecSnapshots {
const snapshots: ExecSnapshots = [];
execResults.forEach((execResult) => {
--
GitLab