From ce2318765fa5404fdba59c9fbe0f5efa1fd4c551 Mon Sep 17 00:00:00 2001
From: Michael Kriese <michael.kriese@visualon.de>
Date: Sat, 6 Aug 2022 07:27:07 +0200
Subject: [PATCH] fix: Revert "fix(renovate-config-validator): add validate
presets to the validator" (#17012)
Revert "fix(renovate-config-validator): add validate presets to the validator (#16468)"
This reverts commit 4b0b49e1c65a29880f3f9101d4f2d4e987349c67.
---
lib/config/validation.spec.ts | 20 +-------------------
lib/config/validation.ts | 15 +--------------
2 files changed, 2 insertions(+), 33 deletions(-)
diff --git a/lib/config/validation.spec.ts b/lib/config/validation.spec.ts
index 7a480fbc0d..7e564265a2 100644
--- a/lib/config/validation.spec.ts
+++ b/lib/config/validation.spec.ts
@@ -1,4 +1,3 @@
-import * as httpMock from '../../test/http-mock';
import type { RenovateConfig } from './types';
import * as configValidation from './validation';
@@ -630,24 +629,7 @@ describe('config/validation', () => {
it('validates preset values', async () => {
const config = {
- extends: ['config:base', ':pinVersions', 42] as never,
- };
- const { warnings, errors } = await configValidation.validateConfig(
- config,
- true
- );
- expect(warnings).toHaveLength(0);
- expect(errors).toHaveLength(1);
- });
-
- it('validates if presets exist', async () => {
- httpMock
- .scope('https://registry.npmjs.org')
- .get('/renovate-config-doesntExist')
- .reply(500);
-
- const config = {
- extends: ['config:base', 'doesntExist'] as never,
+ extends: ['foo', 'bar', 42] as never,
};
const { warnings, errors } = await configValidation.validateConfig(
config,
diff --git a/lib/config/validation.ts b/lib/config/validation.ts
index e33ac92bae..a9ba6d08d8 100644
--- a/lib/config/validation.ts
+++ b/lib/config/validation.ts
@@ -1,5 +1,4 @@
import is from '@sindresorhus/is';
-import { logger } from '../logger';
import { getLanguageList, getManagerList } from '../modules/manager';
import { configRegexPredicate, isConfigRegex, regEx } from '../util/regex';
import * as template from '../util/template';
@@ -9,7 +8,7 @@ import {
} from '../workers/repository/update/branch/schedule';
import { migrateConfig } from './migration';
import { getOptions } from './options';
-import { getPreset, resolveConfigPresets } from './presets';
+import { resolveConfigPresets } from './presets';
import type {
RenovateConfig,
RenovateOptions,
@@ -272,18 +271,6 @@ export async function validateConfig(
if (key === 'extends') {
for (const subval of val) {
if (is.string(subval)) {
- try {
- await getPreset(subval, config);
- } catch (err) {
- logger.debug(
- { err, preset: subval },
- `Could not resolve preset during config validation`
- );
- errors.push({
- topic: 'Configuration Warning',
- message: `Invalid Preset ${subval}`,
- });
- }
if (
parentName === 'packageRules' &&
subval.startsWith('group:')
--
GitLab