From cfc4c48a4799b03a72bb29c18c43c2999676c1f0 Mon Sep 17 00:00:00 2001
From: Rhys Arkins <rhys@arkins.net>
Date: Thu, 18 Nov 2021 16:47:17 +0100
Subject: [PATCH] fix(github): handle secondary rate limit (#12741)
---
lib/util/http/github.spec.ts | 8 ++++++++
lib/util/http/github.ts | 7 +++++++
2 files changed, 15 insertions(+)
diff --git a/lib/util/http/github.spec.ts b/lib/util/http/github.spec.ts
index 67fc7e5a2c..9f9340264c 100644
--- a/lib/util/http/github.spec.ts
+++ b/lib/util/http/github.spec.ts
@@ -192,6 +192,14 @@ describe('util/http/github', () => {
})
).rejects.toThrow(PLATFORM_RATE_LIMIT_EXCEEDED);
});
+ it('should throw secondary rate limit exceeded', async () => {
+ await expect(
+ fail(403, {
+ message:
+ 'You have exceeded a secondary rate limit and have been temporarily blocked from content creation. Please retry your request again later.',
+ })
+ ).rejects.toThrow(PLATFORM_RATE_LIMIT_EXCEEDED);
+ });
it('should throw Bad credentials', async () => {
await expect(
fail(401, { message: 'Bad credentials. (401)' })
diff --git a/lib/util/http/github.ts b/lib/util/http/github.ts
index c181dcb6f1..a96fad6973 100644
--- a/lib/util/http/github.ts
+++ b/lib/util/http/github.ts
@@ -78,6 +78,13 @@ function handleGotError(
logger.debug({ err }, 'GitHub failure: abuse detection');
throw new Error(PLATFORM_RATE_LIMIT_EXCEEDED);
}
+ if (
+ err.statusCode === 403 &&
+ message.startsWith('You have exceeded a secondary rate limit')
+ ) {
+ logger.debug({ err }, 'GitHub failure: secondary rate limit');
+ throw new Error(PLATFORM_RATE_LIMIT_EXCEEDED);
+ }
if (err.statusCode === 403 && message.includes('Upgrade to GitHub Pro')) {
logger.debug({ path }, 'Endpoint needs paid GitHub plan');
throw err;
--
GitLab