From d14c64ad915b83d84c0b6a841510959d8e90b0bd Mon Sep 17 00:00:00 2001 From: Rhys Arkins <rhys@keylocation.sg> Date: Fri, 4 Aug 2017 12:06:32 +0200 Subject: [PATCH] feat: Warn workspaces users (#607) Links to open issue about workspaces. Closes #601 --- lib/workers/package-file/index.js | 6 ++++++ test/workers/package-file/index.spec.js | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/lib/workers/package-file/index.js b/lib/workers/package-file/index.js index 08090c14bd..df2edd564f 100644 --- a/lib/workers/package-file/index.js +++ b/lib/workers/package-file/index.js @@ -31,6 +31,12 @@ async function renovatePackageFile(packageFileConfig) { if (packageContent.workspaces) { logger.warn('Found workspaces'); + const warn = { ...config }; + warn.depName = 'workspaces'; + warn.type = 'warning'; + warn.message = + 'workspaces configuration detected in `package.json` but this is currently unsupported. Please see https://github.com/singapore/renovate/issues/473 for details.'; + upgrades.push(warn); } // Check for renovate config inside the package.json diff --git a/test/workers/package-file/index.spec.js b/test/workers/package-file/index.spec.js index 2282b53507..acacd4630d 100644 --- a/test/workers/package-file/index.spec.js +++ b/test/workers/package-file/index.spec.js @@ -71,7 +71,7 @@ describe('packageFileWorker', () => { depTypeWorker.renovateDepType.mockReturnValueOnce([]); depTypeWorker.renovateDepType.mockReturnValueOnce([]); const res = await packageFileWorker.renovatePackageFile(config); - expect(res).toHaveLength(3); + expect(res).toHaveLength(4); }); it('maintains lock files', async () => { config.api.getFileJson.mockReturnValueOnce({}); -- GitLab