From d1b427b5535e1491f88af27d10dcb9f88929c902 Mon Sep 17 00:00:00 2001
From: Rhys Arkins <rhys@arkins.net>
Date: Wed, 14 Aug 2019 14:29:17 +0200
Subject: [PATCH] fix(docker-compose): skip over dupes
---
lib/manager/docker-compose/extract.ts | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/lib/manager/docker-compose/extract.ts b/lib/manager/docker-compose/extract.ts
index 7696918b5c..3ceb569c08 100644
--- a/lib/manager/docker-compose/extract.ts
+++ b/lib/manager/docker-compose/extract.ts
@@ -30,7 +30,10 @@ class LineMapper {
const lineMeta = this.imageLines.find(
({ line, used }) => !used && line.includes(imageName)
);
-
+ // istanbul ignore if
+ if (!lineMeta) {
+ return null;
+ }
lineMeta.used = true; // unset plucked lines so duplicates are skipped
return lineMeta.lineNumber;
}
@@ -66,9 +69,14 @@ export function extractPackageFile(
.map(service => {
const dep = getDep(service.image);
const lineNumber = lineMapper.pluckLineNumber(service.image);
+ // istanbul ignore if
+ if (!lineNumber) {
+ return null;
+ }
dep.managerData = { lineNumber };
return dep;
- });
+ })
+ .filter(Boolean);
logger.trace({ deps }, 'Docker Compose image');
if (!deps.length) {
--
GitLab