From d742732e2b549b73e47c3d81ed677e676a4da84d Mon Sep 17 00:00:00 2001 From: Rhys Arkins <rhys@arkins.net> Date: Mon, 9 Apr 2018 13:28:08 +0200 Subject: [PATCH] fix: set isRange true for non-version docker tags Closes #1806 --- lib/manager/docker/package.js | 2 +- test/manager/docker/package.spec.js | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/manager/docker/package.js b/lib/manager/docker/package.js index ab578effaa..c4a3a9f274 100644 --- a/lib/manager/docker/package.js +++ b/lib/manager/docker/package.js @@ -64,7 +64,7 @@ async function getPackageUpdates(config) { { currentDepTag }, 'Docker tag is not valid semver - skipping' ); - return upgrades; + return upgrades.map(upgrade => ({ ...upgrade, isRange: true })); } const currentMajor = semver.major(padRange(tagVersion)); const currentlyStable = isStable(tagVersion, unstablePattern); diff --git a/test/manager/docker/package.spec.js b/test/manager/docker/package.spec.js index 680277f9e3..f8bd76e5d7 100644 --- a/test/manager/docker/package.spec.js +++ b/test/manager/docker/package.spec.js @@ -65,6 +65,7 @@ describe('lib/workers/package/docker', () => { }); it('returns a pin', async () => { delete config.currentDigest; + config.currentTag = 'some-text-tag'; dockerApi.getDigest.mockReturnValueOnce('sha256:1234567890'); const res = await docker.getPackageUpdates(config); expect(res).toHaveLength(1); -- GitLab