From d7629ce68d6679bdf548f9295f7930d874c08c34 Mon Sep 17 00:00:00 2001
From: Rhys Arkins <rhys@arkins.net>
Date: Tue, 29 Jan 2019 14:12:32 +0100
Subject: [PATCH] fix(datasource): remove unused normalize qualifier
---
lib/datasource/index.js | 5 -----
.../__snapshots__/github.spec.js.snap | 16 ----------------
test/datasource/github.spec.js | 17 -----------------
3 files changed, 38 deletions(-)
diff --git a/lib/datasource/index.js b/lib/datasource/index.js
index b6134555c6..ced1e747db 100644
--- a/lib/datasource/index.js
+++ b/lib/datasource/index.js
@@ -55,11 +55,6 @@ async function getPkgReleases(config) {
res.releases = res.releases
.filter(release => isVersion(release.version))
.sort(sortReleases);
- if (parse(config.purl).qualifiers.normalize === 'true') {
- for (const release of res.releases) {
- release.version = isVersion(release.version);
- }
- }
}
return res;
}
diff --git a/test/datasource/__snapshots__/github.spec.js.snap b/test/datasource/__snapshots__/github.spec.js.snap
index 6bb33fe0ed..cf25900a7e 100644
--- a/test/datasource/__snapshots__/github.spec.js.snap
+++ b/test/datasource/__snapshots__/github.spec.js.snap
@@ -1,21 +1,5 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP
-exports[`datasource/github getPkgReleases returns cleaned tags 1`] = `
-Object {
- "releases": Array [
- Object {
- "gitRef": "1.0.0",
- "version": "1.0.0",
- },
- Object {
- "gitRef": "v1.1.0",
- "version": "1.1.0",
- },
- ],
- "sourceUrl": "https://github.com/some/dep",
-}
-`;
-
exports[`datasource/github getPkgReleases returns releases 1`] = `
Object {
"releases": Array [
diff --git a/test/datasource/github.spec.js b/test/datasource/github.spec.js
index e17111ba73..fdc43995b8 100644
--- a/test/datasource/github.spec.js
+++ b/test/datasource/github.spec.js
@@ -62,23 +62,6 @@ describe('datasource/github', () => {
});
describe('getPkgReleases', () => {
beforeAll(() => global.renovateCache.rmAll());
- it('returns cleaned tags', async () => {
- const body = [
- { name: 'a' },
- { name: 'v' },
- { name: '1.0.0' },
- { name: 'v1.1.0' },
- ];
- ghGot.mockReturnValueOnce({ headers: {}, body });
- const res = await datasource.getPkgReleases({
- purl: 'pkg:github/some/dep?normalize=true',
- });
- expect(res).toMatchSnapshot();
- expect(res.releases).toHaveLength(2);
- expect(
- res.releases.find(release => release.version === '1.1.0')
- ).toBeDefined();
- });
it('returns releases', async () => {
const body = [
{ tag_name: 'a' },
--
GitLab