From d982056cd337cc80611f09453cc6911c6ad5dc09 Mon Sep 17 00:00:00 2001
From: Rhys Arkins <rhys@arkins.net>
Date: Sat, 2 Jun 2018 19:36:12 +0200
Subject: [PATCH] fix: skip non-semver nvmrc
---
lib/manager/nvm/extract.js | 21 +++++++++++--------
.../nvm/__snapshots__/extract.spec.js.snap | 12 +++++++++++
test/manager/nvm/extract.spec.js | 4 ++++
3 files changed, 28 insertions(+), 9 deletions(-)
diff --git a/lib/manager/nvm/extract.js b/lib/manager/nvm/extract.js
index 089396e1ac..f96c7c75c5 100644
--- a/lib/manager/nvm/extract.js
+++ b/lib/manager/nvm/extract.js
@@ -1,15 +1,18 @@
+const semver = require('../../versioning/semver');
+
module.exports = {
extractDependencies,
};
function extractDependencies(content) {
- const deps = [
- {
- depName: 'node',
- currentVersion: content.trim(),
- purl: 'pkg:github/nodejs/node?clean=true',
- versionScheme: 'semver',
- },
- ];
- return { deps };
+ const dep = {
+ depName: 'node',
+ currentVersion: content.trim(),
+ purl: 'pkg:github/nodejs/node?clean=true',
+ versionScheme: 'semver',
+ };
+ if (!semver.isPinnedVersion(dep.currentVersion)) {
+ dep.skipReason = 'unsupported-version';
+ }
+ return { deps: [dep] };
}
diff --git a/test/manager/nvm/__snapshots__/extract.spec.js.snap b/test/manager/nvm/__snapshots__/extract.spec.js.snap
index 2f94798327..d909afc4e4 100644
--- a/test/manager/nvm/__snapshots__/extract.spec.js.snap
+++ b/test/manager/nvm/__snapshots__/extract.spec.js.snap
@@ -10,3 +10,15 @@ Array [
},
]
`;
+
+exports[`lib/manager/nvm/extract extractDependencies() skips non-pinned 1`] = `
+Array [
+ Object {
+ "currentVersion": "8.4",
+ "depName": "node",
+ "purl": "pkg:github/nodejs/node?clean=true",
+ "skipReason": "unsupported-version",
+ "versionScheme": "semver",
+ },
+]
+`;
diff --git a/test/manager/nvm/extract.spec.js b/test/manager/nvm/extract.spec.js
index 55f9480e7d..bd6f1c2e47 100644
--- a/test/manager/nvm/extract.spec.js
+++ b/test/manager/nvm/extract.spec.js
@@ -6,5 +6,9 @@ describe('lib/manager/nvm/extract', () => {
const res = extractDependencies('8.4.0\n');
expect(res.deps).toMatchSnapshot();
});
+ it('skips non-pinned', () => {
+ const res = extractDependencies('8.4\n');
+ expect(res.deps).toMatchSnapshot();
+ });
});
});
--
GitLab