From e061ce628d4bcd31db4a2c150d0e5ef4fb67eaf2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jonatan=20M=C3=A4nnchen?= <jonatan@maennchen.ch>
Date: Fri, 25 Nov 2022 16:10:47 +0100
Subject: [PATCH] chore: Disable consistent-return eslint rule (#19101)

---
 .eslintrc.js | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/.eslintrc.js b/.eslintrc.js
index a94937b179..95517d09e2 100644
--- a/.eslintrc.js
+++ b/.eslintrc.js
@@ -41,8 +41,16 @@ module.exports = {
     ],
     'import/prefer-default-export': 0, // no benefit
 
+    /*
+     * This rule is not needed since the project uses typescript and the rule
+     * `@typescript-eslint/explicit-function-return-type`.
+     *
+     * Any non-exhaustive definition of the function will therefore result in a
+     * typescript TS2366 error.
+     */
+    'consistent-return': 0,
+
     // other rules
-    'consistent-return': 'error',
     eqeqeq: 'error',
     'no-console': 'error',
     'no-negated-condition': 'error',
-- 
GitLab