From e12d8f04372ad22d7d891b8d44957e9c6c6a2338 Mon Sep 17 00:00:00 2001
From: Rhys Arkins <rhys@arkins.net>
Date: Mon, 3 Feb 2020 14:16:23 +0100
Subject: [PATCH] refactor: remove unnecessary manager literals

---
 lib/manager/gradle/index.ts                                 | 2 --
 lib/manager/npm/extract/index.ts                            | 2 --
 lib/manager/pub/extract.ts                                  | 2 --
 test/manager/gradle/__snapshots__/index.spec.ts.snap        | 6 ------
 test/manager/pub/__snapshots__/extract.spec.ts.snap         | 1 -
 .../extract/__snapshots__/manager-files.spec.ts.snap        | 1 -
 6 files changed, 14 deletions(-)

diff --git a/lib/manager/gradle/index.ts b/lib/manager/gradle/index.ts
index eb3ad53ade..0817e065c7 100644
--- a/lib/manager/gradle/index.ts
+++ b/lib/manager/gradle/index.ts
@@ -18,7 +18,6 @@ import {
 import { PackageFile, ExtractConfig, Upgrade } from '../common';
 import { platform } from '../../platform';
 import { LANGUAGE_JAVA } from '../../constants/languages';
-import { MANAGER_GRADLE } from '../../constants/managers';
 import { DATASOURCE_MAVEN } from '../../constants/data-binary-source';
 import { BinarySource } from '../../util/exec/common';
 
@@ -144,7 +143,6 @@ export async function extractAllPackageFiles(
     if (content) {
       gradleFiles.push({
         packageFile,
-        manager: MANAGER_GRADLE,
         datasource: DATASOURCE_MAVEN,
         deps: dependencies,
       });
diff --git a/lib/manager/npm/extract/index.ts b/lib/manager/npm/extract/index.ts
index 387aa2af3a..449dc6f03a 100644
--- a/lib/manager/npm/extract/index.ts
+++ b/lib/manager/npm/extract/index.ts
@@ -18,7 +18,6 @@ import { NpmPackage } from './common';
 import { platform } from '../../../platform';
 import { CONFIG_VALIDATION } from '../../../constants/error-messages';
 import { VERSION_SCHEME_NODE } from '../../../constants/version-schemes';
-import { MANAGER_NPM } from '../../../constants/managers';
 import {
   DATASOURCE_GITHUB,
   DATASOURCE_NPM,
@@ -354,7 +353,6 @@ export async function extractAllPackageFiles(
       if (deps) {
         npmFiles.push({
           packageFile,
-          manager: MANAGER_NPM,
           ...deps,
         });
       }
diff --git a/lib/manager/pub/extract.ts b/lib/manager/pub/extract.ts
index b828733ecb..2dd2baff12 100644
--- a/lib/manager/pub/extract.ts
+++ b/lib/manager/pub/extract.ts
@@ -2,7 +2,6 @@ import { safeLoad } from 'js-yaml';
 import { isValid } from '../../versioning/npm/index';
 import { logger } from '../../logger';
 import { PackageDependency, PackageFile } from '../common';
-import { MANAGER_PUB } from '../../constants/managers';
 import { DATASOURCE_DART } from '../../constants/data-binary-source';
 
 function getDeps(
@@ -51,7 +50,6 @@ export function extractPackageFile(
     if (deps.length) {
       return {
         packageFile,
-        manager: MANAGER_PUB,
         datasource: DATASOURCE_DART,
         deps,
       };
diff --git a/test/manager/gradle/__snapshots__/index.spec.ts.snap b/test/manager/gradle/__snapshots__/index.spec.ts.snap
index 06f1e8de21..7e8e6c8d3b 100644
--- a/test/manager/gradle/__snapshots__/index.spec.ts.snap
+++ b/test/manager/gradle/__snapshots__/index.spec.ts.snap
@@ -168,7 +168,6 @@ Array [
         ],
       },
     ],
-    "manager": "gradle",
     "packageFile": "build.gradle",
   },
   Object {
@@ -227,7 +226,6 @@ Array [
         ],
       },
     ],
-    "manager": "gradle",
     "packageFile": "subproject/build.gradle",
   },
 ]
@@ -313,7 +311,6 @@ Array [
         ],
       },
     ],
-    "manager": "gradle",
     "packageFile": "foo/build.gradle",
   },
 ]
@@ -399,7 +396,6 @@ Array [
         ],
       },
     ],
-    "manager": "gradle",
     "packageFile": "build.gradle.kts",
   },
   Object {
@@ -458,7 +454,6 @@ Array [
         ],
       },
     ],
-    "manager": "gradle",
     "packageFile": "subproject/build.gradle.kts",
   },
 ]
@@ -613,7 +608,6 @@ Array [
         ],
       },
     ],
-    "manager": "gradle",
     "packageFile": "build.gradle",
   },
 ]
diff --git a/test/manager/pub/__snapshots__/extract.spec.ts.snap b/test/manager/pub/__snapshots__/extract.spec.ts.snap
index a586ba4fad..890b12bb61 100644
--- a/test/manager/pub/__snapshots__/extract.spec.ts.snap
+++ b/test/manager/pub/__snapshots__/extract.spec.ts.snap
@@ -37,7 +37,6 @@ Object {
       "depType": "dev_dependencies",
     },
   ],
-  "manager": "pub",
   "packageFile": "pubspec.yaml",
 }
 `;
diff --git a/test/workers/repository/extract/__snapshots__/manager-files.spec.ts.snap b/test/workers/repository/extract/__snapshots__/manager-files.spec.ts.snap
index d98965c952..f98c29eb44 100644
--- a/test/workers/repository/extract/__snapshots__/manager-files.spec.ts.snap
+++ b/test/workers/repository/extract/__snapshots__/manager-files.spec.ts.snap
@@ -8,7 +8,6 @@ Array [
     "lernaClient": "yarn",
     "lernaDir": ".",
     "lernaPackages": undefined,
-    "manager": "npm",
     "npmLock": "package-lock.json",
     "npmrc": "{}",
     "packageFile": "package.json",
-- 
GitLab