From e541f3ed2869d4fcca446521f7d334acedbae098 Mon Sep 17 00:00:00 2001
From: Rhys Arkins <rhys@arkins.net>
Date: Sat, 27 Mar 2021 07:15:36 +0100
Subject: [PATCH] fix(npm): drop defensive catches to stop on errors
---
lib/manager/npm/post-update/index.ts | 34 +++++++++-------------------
1 file changed, 11 insertions(+), 23 deletions(-)
diff --git a/lib/manager/npm/post-update/index.ts b/lib/manager/npm/post-update/index.ts
index 083272c161..e966a58a6a 100644
--- a/lib/manager/npm/post-update/index.ts
+++ b/lib/manager/npm/post-update/index.ts
@@ -139,11 +139,7 @@ export async function writeExistingFiles(
const npmrc: string = packageFile.npmrc || config.npmrc;
const npmrcFilename = upath.join(basedir, '.npmrc');
if (is.string(npmrc)) {
- try {
- await outputFile(npmrcFilename, `${npmrc}\n`);
- } catch (err) /* istanbul ignore next */ {
- logger.warn({ npmrcFilename, err }, 'Error writing .npmrc');
- }
+ await outputFile(npmrcFilename, `${npmrc}\n`);
} else if (config.ignoreNpmrcFile) {
logger.debug('Removing ignored .npmrc file before artifact generation');
await remove(npmrcFilename);
@@ -151,16 +147,12 @@ export async function writeExistingFiles(
if (packageFile.yarnrc) {
logger.debug(`Writing .yarnrc to ${basedir}`);
const yarnrcFilename = upath.join(basedir, '.yarnrc');
- try {
- await outputFile(
- yarnrcFilename,
- packageFile.yarnrc
- .replace('--install.pure-lockfile true', '')
- .replace('--install.frozen-lockfile true', '')
- );
- } catch (err) /* istanbul ignore next */ {
- logger.warn({ yarnrcFilename, err }, 'Error writing .yarnrc');
- }
+ await outputFile(
+ yarnrcFilename,
+ packageFile.yarnrc
+ .replace('--install.pure-lockfile true', '')
+ .replace('--install.frozen-lockfile true', '')
+ );
}
const { npmLock } = packageFile;
if (npmLock) {
@@ -304,14 +296,10 @@ async function updateNpmrcContent(
const newNpmrc = originalContent
? [originalContent, ...additionalLines]
: additionalLines;
- try {
- const newContent = newNpmrc.join('\n');
- if (newContent !== originalContent) {
- logger.debug(`Writing updated .npmrc file to ${npmrcFilePath}`);
- await writeFile(npmrcFilePath, `${newContent}\n`);
- }
- } catch {
- logger.warn('Unable to write custom npmrc file');
+ const newContent = newNpmrc.join('\n');
+ if (newContent !== originalContent) {
+ logger.debug(`Writing updated .npmrc file to ${npmrcFilePath}`);
+ await writeFile(npmrcFilePath, `${newContent}\n`);
}
}
--
GitLab