From ec2154963a8b55f1b4fecd5a46123828513a8583 Mon Sep 17 00:00:00 2001 From: Sergio Zharinov <zharinov@users.noreply.github.com> Date: Fri, 11 Sep 2020 22:35:57 +0400 Subject: [PATCH] fix(dependency-dashboard): Force checked PRs creation (#7253) * fix(dependency-dashboard): Force checked PRs creation * Simplify * Remove unused check --- lib/workers/pr/index.spec.ts | 16 ++++++++++++++++ lib/workers/pr/index.ts | 2 +- 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/lib/workers/pr/index.spec.ts b/lib/workers/pr/index.spec.ts index 24cbecbc1a..988e78d1d7 100644 --- a/lib/workers/pr/index.spec.ts +++ b/lib/workers/pr/index.spec.ts @@ -271,6 +271,22 @@ describe('workers/pr', () => { expect(prResult).toEqual(PrResult.LimitReached); expect(platform.createPr.mock.calls).toBeEmpty(); }); + it('should create PR if limit is reached but dashboard checked', async () => { + platform.getBranchStatus.mockResolvedValueOnce(BranchStatus.green); + config.logJSON = await getChangeLogJSON(config); + config.prCreation = 'status-success'; + config.automerge = true; + config.schedule = ['before 5am']; + const { prResult } = await prWorker.ensurePr( + { + ...config, + dependencyDashboardChecks: { 'renovate/dummy-1.x': 'true' }, + }, + true + ); + expect(prResult).toEqual(PrResult.Created); + expect(platform.createPr).toHaveBeenCalled(); + }); it('should create group PR', async () => { config.upgrades = config.upgrades.concat([ { diff --git a/lib/workers/pr/index.ts b/lib/workers/pr/index.ts index bb89380594..6116a38b1f 100644 --- a/lib/workers/pr/index.ts +++ b/lib/workers/pr/index.ts @@ -363,7 +363,7 @@ export async function ensurePr( config.automergeType === 'pr' && config.gitLabAutomerge, }; - if (prLimitReached) { + if (!dependencyDashboardCheck && prLimitReached) { return { prResult: PrResult.LimitReached }; } pr = await platform.createPr({ -- GitLab