From fd85d068f474855703acefac349178caa51a201b Mon Sep 17 00:00:00 2001
From: Rhys Arkins <rhys@arkins.net>
Date: Mon, 4 Feb 2019 21:49:49 +0100
Subject: [PATCH] fix: trim urls from getPkgReleases
Closes #3169
---
lib/datasource/metadata.js | 4 +++-
test/datasource/index.spec.js | 10 ++++++++++
2 files changed, 13 insertions(+), 1 deletion(-)
diff --git a/lib/datasource/metadata.js b/lib/datasource/metadata.js
index 30cee026e0..52e40fabc9 100644
--- a/lib/datasource/metadata.js
+++ b/lib/datasource/metadata.js
@@ -91,7 +91,9 @@ function addMetaData(dep, datasource, lookupName) {
// Clean up any empty urls
const urls = ['homepage', 'sourceUrl', 'changelogUrl'];
for (const url of urls) {
- if (!is.nonEmptyString(dep[url])) {
+ if (is.nonEmptyString(dep[url])) {
+ dep[url] = dep[url].trim();
+ } else {
delete dep[url];
}
}
diff --git a/test/datasource/index.spec.js b/test/datasource/index.spec.js
index b752e9224a..ab10c10cbb 100644
--- a/test/datasource/index.spec.js
+++ b/test/datasource/index.spec.js
@@ -52,4 +52,14 @@ describe('datasource/index', () => {
expect(res).toMatchSnapshot();
expect(res.sourceUrl).toBeDefined();
});
+ it('trims sourceUrl', async () => {
+ npmDatasource.getPkgReleases.mockReturnValue({
+ sourceUrl: ' https://abc.com',
+ });
+ const res = await datasource.getPkgReleases({
+ datasource: 'npm',
+ depName: 'abc',
+ });
+ expect(res.sourceUrl).toEqual('https://abc.com');
+ });
});
--
GitLab