From fee4f0881cbe8c97bef547f73c36e1aa0ad24cf4 Mon Sep 17 00:00:00 2001
From: Rhys Arkins <rhys@arkins.net>
Date: Sat, 15 May 2021 00:08:12 +0200
Subject: [PATCH] fix: defensive isVersion when finding parent
---
lib/manager/npm/update/locked-dependency/parent-version.ts | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/lib/manager/npm/update/locked-dependency/parent-version.ts b/lib/manager/npm/update/locked-dependency/parent-version.ts
index e821825a20..431f069c30 100644
--- a/lib/manager/npm/update/locked-dependency/parent-version.ts
+++ b/lib/manager/npm/update/locked-dependency/parent-version.ts
@@ -35,6 +35,7 @@ export async function findFirstParentVersion(
.map((release) => release.version)
.filter(
(version) =>
+ semver.isVersion(version) &&
semver.isStable(version) &&
(version === targetVersion ||
semver.isGreaterThan(version, targetVersion))
@@ -56,6 +57,7 @@ export async function findFirstParentVersion(
.map((release) => release.version)
.filter(
(version) =>
+ semver.isVersion(version) &&
semver.isStable(version) &&
(version === parentStartingVersion ||
semver.isGreaterThan(version, parentStartingVersion))
@@ -99,7 +101,10 @@ export async function findFirstParentVersion(
}
}
} catch (err) /* istanbul ignore next */ {
- logger.warn({ err }, 'findFirstParentVersion error');
+ logger.warn(
+ { parentName, parentStartingVersion, targetDepName, targetVersion, err },
+ 'findFirstParentVersion error'
+ );
return null;
}
logger.debug(`Could not find a matching version`);
--
GitLab