Skip to content
Snippets Groups Projects
  • jNullj's avatar
    35dfd75e
    Fix: [GithubCommitActivity] invalid branch error handling (#9258) · 35dfd75e
    jNullj authored
    
    * Fix error handling of bad branch in [GithubCommitActivity]
    
    When GraphQL response with a bad repo it returns an error indicating the bad repo.
    When GraphQL has the currect repo with a bad branch it will null inside the repo object without an error object.
    The privouse commits seems to try and use that but due not allowing null in schema it did not work and an error due to bad schema would show insted.
    
    This commit fixes this issue
    
    * Add test for invalid branch in [GithubCommitActivity]
    
    ---------
    
    Co-authored-by: default avatarjNullj <jNullj@users.noreply.github.com>
    35dfd75e
    History
    Fix: [GithubCommitActivity] invalid branch error handling (#9258)
    jNullj authored
    
    * Fix error handling of bad branch in [GithubCommitActivity]
    
    When GraphQL response with a bad repo it returns an error indicating the bad repo.
    When GraphQL has the currect repo with a bad branch it will null inside the repo object without an error object.
    The privouse commits seems to try and use that but due not allowing null in schema it did not work and an error due to bad schema would show insted.
    
    This commit fixes this issue
    
    * Add test for invalid branch in [GithubCommitActivity]
    
    ---------
    
    Co-authored-by: default avatarjNullj <jNullj@users.noreply.github.com>