server.js · 83ac6ff1b3cd182555c6561c7ba74cfcd8e6feb7 · GitHub Mirror / shields.io / shields

6 years ago

Enforce use of template literals (#2242) · 83ac6ff1

Paul Melnikow authored 6 years ago

This is consistent with what we're pretty much already doing, and saves us from making the request during code review.

These were all autofixed and most of them seem easier to read. Some in the legacy services should be rewritten in more legible forms during refactor (ie using intermediate variables, or using request’s qs option). There are some in helper functions and elsewhere that should get rewritten separately. I don't want to change them in this PR because the changes will get lost in this diff, though we could identify them here and fix them before or just after.

83ac6ff1

History

Enforce use of template literals (#2242)

Paul Melnikow authored 6 years ago

This is consistent with what we're pretty much already doing, and saves us from making the request during code review.

These were all autofixed and most of them seem easier to read. Some in the legacy services should be rewritten in more legible forms during refactor (ie using intermediate variables, or using request’s qs option). There are some in helper functions and elsewhere that should get rewritten separately. I don't want to change them in this PR because the changes will get lost in this diff, though we could identify them here and fix them before or just after.

getting-started NaN GiB