From 0aee712738f0df50cfa6c62d7cf65b053c1e73fa Mon Sep 17 00:00:00 2001
From: Paul Melnikow <github@paulmelnikow.com>
Date: Sat, 1 Dec 2018 15:10:32 -0500
Subject: [PATCH] Fix crash in legacy service (#2437)
Bug in #2360
---
lib/request-handler.js | 4 ++++
services/legacy-service.js | 2 +-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/lib/request-handler.js b/lib/request-handler.js
index e9938da800..357f66237a 100644
--- a/lib/request-handler.js
+++ b/lib/request-handler.js
@@ -74,6 +74,10 @@ function flattenQueryParams(queryParams) {
//
// Pass just the handler function as shorthand.
function handleRequest(cacheHeaderConfig, handlerOptions) {
+ if (!cacheHeaderConfig) {
+ throw Error('cacheHeaderConfig is required')
+ }
+
if (typeof handlerOptions === 'function') {
handlerOptions = { handler: handlerOptions }
}
diff --git a/services/legacy-service.js b/services/legacy-service.js
index ebf6e3514e..a67a1af766 100644
--- a/services/legacy-service.js
+++ b/services/legacy-service.js
@@ -9,7 +9,7 @@ class LegacyService extends BaseService {
}
static register({ camp, handleRequest, githubApiProvider }, serviceConfig) {
- const { cache: cacheHeaderConfig } = serviceConfig
+ const { cacheHeaders: cacheHeaderConfig } = serviceConfig
this.registerLegacyRouteHandler({
camp,
cache: (...args) => handleRequest(cacheHeaderConfig, ...args),
--
GitLab