From 1b0712620715ac83876bc0c70d6804a8c7ae7576 Mon Sep 17 00:00:00 2001
From: "dependabot-preview[bot]"
<27856297+dependabot-preview[bot]@users.noreply.github.com>
Date: Sat, 1 May 2021 21:05:02 -0500
Subject: [PATCH] Build(deps-dev): bump eslint-plugin-promise from 4.3.1 to
5.1.0 (#6412)
* Build(deps-dev): bump eslint-plugin-promise from 4.3.1 to 5.1.0
Bumps [eslint-plugin-promise](https://github.com/xjamundx/eslint-plugin-promise) from 4.3.1 to 5.1.0.
- [Release notes](https://github.com/xjamundx/eslint-plugin-promise/releases)
- [Changelog](https://github.com/xjamundx/eslint-plugin-promise/blob/development/CHANGELOG.md)
- [Commits](https://github.com/xjamundx/eslint-plugin-promise/commits)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
* chore: correct false eslint positives
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Caleb Cartwright <caleb.cartwright@outlook.com>
Co-authored-by: Caleb Cartwright <calebcartwright@users.noreply.github.com>
---
core/base-service/legacy-request-handler.js | 2 ++
core/service-test-runner/service-tester.js | 2 +-
package-lock.json | 22 ++++++++++++---------
package.json | 2 +-
services/suggest.js | 1 +
5 files changed, 18 insertions(+), 11 deletions(-)
diff --git a/core/base-service/legacy-request-handler.js b/core/base-service/legacy-request-handler.js
index a6b8d72b5f..e12170226d 100644
--- a/core/base-service/legacy-request-handler.js
+++ b/core/base-service/legacy-request-handler.js
@@ -198,7 +198,9 @@ function handleRequest(cacheHeaderConfig, handlerOptions) {
},
cachingRequest
)
+ // eslint-disable-next-line promise/prefer-await-to-then
if (result && result.catch) {
+ // eslint-disable-next-line promise/prefer-await-to-then
result.catch(err => {
throw err
})
diff --git a/core/service-test-runner/service-tester.js b/core/service-test-runner/service-tester.js
index a8130b7738..4aa282f853 100644
--- a/core/service-test-runner/service-tester.js
+++ b/core/service-test-runner/service-tester.js
@@ -84,7 +84,7 @@ class ServiceTester {
.before(() => {
this.beforeEach()
})
- // eslint-disable-next-line mocha/prefer-arrow-callback
+ // eslint-disable-next-line mocha/prefer-arrow-callback, promise/prefer-await-to-then
.finally(function () {
// `this` is the IcedFrisby instance.
let responseBody
diff --git a/package-lock.json b/package-lock.json
index b943d49a0b..8d4edb5ace 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -95,7 +95,7 @@
"eslint-plugin-mocha": "^8.1.0",
"eslint-plugin-no-extension-in-require": "^0.2.0",
"eslint-plugin-node": "^11.1.0",
- "eslint-plugin-promise": "^4.3.1",
+ "eslint-plugin-promise": "^5.1.0",
"eslint-plugin-react": "^7.23.2",
"eslint-plugin-react-hooks": "^4.2.0",
"eslint-plugin-sort-class-members": "^1.11.0",
@@ -11480,12 +11480,15 @@
}
},
"node_modules/eslint-plugin-promise": {
- "version": "4.3.1",
- "resolved": "https://registry.npmjs.org/eslint-plugin-promise/-/eslint-plugin-promise-4.3.1.tgz",
- "integrity": "sha512-bY2sGqyptzFBDLh/GMbAxfdJC+b0f23ME63FOE4+Jao0oZ3E1LEwFtWJX/1pGMJLiTtrSSern2CRM/g+dfc0eQ==",
+ "version": "5.1.0",
+ "resolved": "https://registry.npmjs.org/eslint-plugin-promise/-/eslint-plugin-promise-5.1.0.tgz",
+ "integrity": "sha512-NGmI6BH5L12pl7ScQHbg7tvtk4wPxxj8yPHH47NvSmMtFneC077PSeY3huFj06ZWZvtbfxSPt3RuOQD5XcR4ng==",
"dev": true,
"engines": {
- "node": ">=6"
+ "node": "^10.12.0 || >=12.0.0"
+ },
+ "peerDependencies": {
+ "eslint": "^7.0.0"
}
},
"node_modules/eslint-plugin-react": {
@@ -45497,10 +45500,11 @@
}
},
"eslint-plugin-promise": {
- "version": "4.3.1",
- "resolved": "https://registry.npmjs.org/eslint-plugin-promise/-/eslint-plugin-promise-4.3.1.tgz",
- "integrity": "sha512-bY2sGqyptzFBDLh/GMbAxfdJC+b0f23ME63FOE4+Jao0oZ3E1LEwFtWJX/1pGMJLiTtrSSern2CRM/g+dfc0eQ==",
- "dev": true
+ "version": "5.1.0",
+ "resolved": "https://registry.npmjs.org/eslint-plugin-promise/-/eslint-plugin-promise-5.1.0.tgz",
+ "integrity": "sha512-NGmI6BH5L12pl7ScQHbg7tvtk4wPxxj8yPHH47NvSmMtFneC077PSeY3huFj06ZWZvtbfxSPt3RuOQD5XcR4ng==",
+ "dev": true,
+ "requires": {}
},
"eslint-plugin-react": {
"version": "7.23.2",
diff --git a/package.json b/package.json
index ef2bcf371c..136bd17923 100644
--- a/package.json
+++ b/package.json
@@ -183,7 +183,7 @@
"eslint-plugin-mocha": "^8.1.0",
"eslint-plugin-no-extension-in-require": "^0.2.0",
"eslint-plugin-node": "^11.1.0",
- "eslint-plugin-promise": "^4.3.1",
+ "eslint-plugin-promise": "^5.1.0",
"eslint-plugin-react": "^7.23.2",
"eslint-plugin-react-hooks": "^4.2.0",
"eslint-plugin-sort-class-members": "^1.11.0",
diff --git a/services/suggest.js b/services/suggest.js
index ac1c689393..432c000001 100644
--- a/services/suggest.js
+++ b/services/suggest.js
@@ -193,6 +193,7 @@ function setRoutes(allowedOrigin, githubApiProvider, server) {
.then(suggestions => {
end({ suggestions })
})
+ // eslint-disable-next-line promise/prefer-await-to-then
.catch(err => {
end({ suggestions: [], err })
})
--
GitLab