From 27a2deb7d21e3b107c2e1092cb0703c43ae77d6d Mon Sep 17 00:00:00 2001
From: chris48s <chris48s@users.noreply.github.com>
Date: Mon, 16 Jan 2023 23:20:53 +0000
Subject: [PATCH] remove danger-plugin-no-test-shortcuts (#8815)
Co-authored-by: repo-ranger[bot] <39074581+repo-ranger[bot]@users.noreply.github.com>
---
dangerfile.js | 9 ---------
package-lock.json | 19 -------------------
package.json | 1 -
3 files changed, 29 deletions(-)
diff --git a/dangerfile.js b/dangerfile.js
index 930030dc9a..2806b12b84 100644
--- a/dangerfile.js
+++ b/dangerfile.js
@@ -11,7 +11,6 @@
// DANGER_GITHUB_API_TOKEN=your-github-api-token npm run danger -- pr https://github.com/badges/shields/pull/2665
const { danger, fail, message, warn } = require('danger')
-const { default: noTestShortcuts } = require('danger-plugin-no-test-shortcuts')
const { fileMatch } = danger.git
const documentation = fileMatch(
@@ -173,11 +172,3 @@ affectedServices.forEach(service => {
)
}
})
-
-// Prevent merging exclusive services tests.
-noTestShortcuts({
- testFilePredicate: filePath => filePath.endsWith('.tester.js'),
- patterns: {
- only: ['only()'],
- },
-})
diff --git a/package-lock.json b/package-lock.json
index ddb6be3643..dd1fdc3e5e 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -86,7 +86,6 @@
"cypress": "^12.3.0",
"cypress-wait-for-stable-dom": "^0.1.0",
"danger": "^11.2.1",
- "danger-plugin-no-test-shortcuts": "^2.0.0",
"deepmerge": "^4.2.2",
"eslint": "^7.32.0",
"eslint-config-prettier": "^8.6.0",
@@ -10541,15 +10540,6 @@
"node": ">=14.13.1"
}
},
- "node_modules/danger-plugin-no-test-shortcuts": {
- "version": "2.0.0",
- "resolved": "https://registry.npmjs.org/danger-plugin-no-test-shortcuts/-/danger-plugin-no-test-shortcuts-2.0.0.tgz",
- "integrity": "sha1-Atu3JFWBlFTTbNWVLi/w9H34ENo=",
- "dev": true,
- "dependencies": {
- "lodash": "^4.17.4"
- }
- },
"node_modules/danger/node_modules/ansi-styles": {
"version": "3.2.1",
"resolved": "https://registry.npmjs.org/ansi-styles/-/ansi-styles-3.2.1.tgz",
@@ -38048,15 +38038,6 @@
}
}
},
- "danger-plugin-no-test-shortcuts": {
- "version": "2.0.0",
- "resolved": "https://registry.npmjs.org/danger-plugin-no-test-shortcuts/-/danger-plugin-no-test-shortcuts-2.0.0.tgz",
- "integrity": "sha1-Atu3JFWBlFTTbNWVLi/w9H34ENo=",
- "dev": true,
- "requires": {
- "lodash": "^4.17.4"
- }
- },
"dashdash": {
"version": "1.14.1",
"resolved": "https://registry.npmjs.org/dashdash/-/dashdash-1.14.1.tgz",
diff --git a/package.json b/package.json
index 38cb369514..04bd962f5e 100644
--- a/package.json
+++ b/package.json
@@ -172,7 +172,6 @@
"cypress": "^12.3.0",
"cypress-wait-for-stable-dom": "^0.1.0",
"danger": "^11.2.1",
- "danger-plugin-no-test-shortcuts": "^2.0.0",
"deepmerge": "^4.2.2",
"eslint": "^7.32.0",
"eslint-config-prettier": "^8.6.0",
--
GitLab