diff --git a/gh-badges/lib/make-badge.spec.js b/gh-badges/lib/make-badge.spec.js index f4bfd189dc95d67ff6d98e4cd8e36e4a7c8ff70f..1466f50d477d53bcfa357ef618a341ceaee44129 100644 --- a/gh-badges/lib/make-badge.spec.js +++ b/gh-badges/lib/make-badge.spec.js @@ -64,7 +64,7 @@ describe('The badge generator', function() { given('almostred'), given('brightmaroon'), given('cactus') - ).expect(undefined) + ).expect(null) }) }) diff --git a/gh-badges/templates/_shields_test-template.json b/gh-badges/templates/_shields_test-template.json index 3821a8cb05dfdff9d724a1e82112569138df1f79..e39706a9568a586dbaac7894781c387dcad68e3f 100644 --- a/gh-badges/templates/_shields_test-template.json +++ b/gh-badges/templates/_shields_test-template.json @@ -1,9 +1,7 @@ { -{{?it.color}} - "color": {{=JSON.stringify(it.color)}}, -{{?}} + "color": {{=JSON.stringify(it.color || null)}}, {{?it.labelColor}} - "labelColor": {{=JSON.stringify(it.labelColor)}} + "labelColor": {{=JSON.stringify(it.labelColor)}}, {{?}} "name": {{=JSON.stringify(it.text[0])}}, "value": {{=JSON.stringify(it.text[1])}} diff --git a/lib/badge-data.js b/lib/badge-data.js index dc75f84eea58c0466458d3d6ca28218205ed3786..f2931dc8e60c60615c5e830f17a0939ab8997968 100644 --- a/lib/badge-data.js +++ b/lib/badge-data.js @@ -107,8 +107,14 @@ function makeBadgeData(defaultLabel, overrides) { logoWidth: +overrides.logoWidth, links: toArray(overrides.link), // Scoutcamp sometimes turns these into numbers. - colorA: `${overrides.colorA}`, - colorB: `${overrides.colorB}`, + colorA: + typeof overrides.colorA === 'number' + ? `${overrides.colorA}` + : overrides.colorA, + colorB: + typeof overrides.colorB === 'number' + ? `${overrides.colorB}` + : overrides.colorB, } } diff --git a/services/github/github-commits-since.tester.js b/services/github/github-commits-since.tester.js index 39d4a65ac23d6ea10cd51423327b93ba9820d92c..2673222373203adb3514d81e860c3b202b2cec5f 100644 --- a/services/github/github-commits-since.tester.js +++ b/services/github/github-commits-since.tester.js @@ -5,11 +5,14 @@ const Joi = require('joi') const t = (module.exports = require('../create-service-tester')()) t.create('Commits since') - .get('/badges/shields/a0663d8da53fb712472c02665e6ff7547ba945b7.json') + .get( + '/badges/shields/a0663d8da53fb712472c02665e6ff7547ba945b7.json?style=_shields_test' + ) .expectJSONTypes( Joi.object().keys({ name: Joi.string().regex(/^(commits since){1}[\s\S]+$/), value: Joi.string().regex(/^\w+$/), + color: 'blue', }) )