From 4ee26bfcdb8336812c85fb4ac72ebd2c1f76343d Mon Sep 17 00:00:00 2001
From: Regev Brody <regevbr@gmail.com>
Date: Mon, 6 Apr 2020 01:41:06 +0300
Subject: [PATCH] node badges are missing descriptions #4871 (#4872)
* fix: node badges are missing descriptions #4871
* fix: node badges are missing descriptions #4871
* fix: node badges are missing descriptions #4871
* Update services/node/node-lts.service.js
Co-Authored-By: Caleb Cartwright <calebcartwright@users.noreply.github.com>
* Update services/node/node-current.service.js
Co-Authored-By: Caleb Cartwright <calebcartwright@users.noreply.github.com>
* Update services/node/node-base.js
Co-Authored-By: Caleb Cartwright <calebcartwright@users.noreply.github.com>
Co-authored-by: Caleb Cartwright <calebcartwright@users.noreply.github.com>
---
services/node/node-base.js | 11 +++++++++++
services/node/node-current.service.js | 4 ++++
services/node/node-lts.service.js | 4 ++++
3 files changed, 19 insertions(+)
diff --git a/services/node/node-base.js b/services/node/node-base.js
index 2af26cb106..a0b9e91275 100644
--- a/services/node/node-base.js
+++ b/services/node/node-base.js
@@ -15,6 +15,12 @@ module.exports = class NodeVersionBase extends NPMBase {
static get examples() {
const type = this.type
+ const documentation = `
+ <p>
+ ${this.documentation}
+ The node version support is retrieved from the <code>engines.node</code> section in package.json.
+ </p>
+`
const prefix = `node-${type}`
return [
{
@@ -25,6 +31,7 @@ module.exports = class NodeVersionBase extends NPMBase {
nodeVersionRange: '>= 6.0.0',
}),
keywords,
+ documentation,
},
{
title: `${prefix} (scoped)`,
@@ -34,6 +41,7 @@ module.exports = class NodeVersionBase extends NPMBase {
nodeVersionRange: '>= 6.0.0',
}),
keywords,
+ documentation,
},
{
title: `${prefix} (tag)`,
@@ -44,6 +52,7 @@ module.exports = class NodeVersionBase extends NPMBase {
tag: 'latest',
}),
keywords,
+ documentation,
},
{
title: `${prefix} (scoped with tag)`,
@@ -54,6 +63,7 @@ module.exports = class NodeVersionBase extends NPMBase {
tag: 'latest',
}),
keywords,
+ documentation,
},
{
title: `${prefix} (scoped with tag, custom registry)`,
@@ -65,6 +75,7 @@ module.exports = class NodeVersionBase extends NPMBase {
tag: 'latest',
}),
keywords,
+ documentation,
},
]
}
diff --git a/services/node/node-current.service.js b/services/node/node-current.service.js
index 27ace3ba4c..62ea26c4b5 100644
--- a/services/node/node-current.service.js
+++ b/services/node/node-current.service.js
@@ -19,4 +19,8 @@ module.exports = class NodeCurrentVersion extends NodeVersionBase {
static get colorResolver() {
return versionColorForRangeCurrent
}
+
+ static get documentation() {
+ return `This badge indicates whether the package supports the <b>latest</b> release of node`
+ }
}
diff --git a/services/node/node-lts.service.js b/services/node/node-lts.service.js
index 73477191eb..cdef9af047 100644
--- a/services/node/node-lts.service.js
+++ b/services/node/node-lts.service.js
@@ -19,4 +19,8 @@ module.exports = class NodeLtsVersion extends NodeVersionBase {
static get colorResolver() {
return versionColorForRangeLts
}
+
+ static get documentation() {
+ return `This badge indicates whether the package supports <b>all</b> LTS node versions`
+ }
}
--
GitLab