From b2af8f7a045b91e64e89472c364573ccecf391ab Mon Sep 17 00:00:00 2001
From: Danial <RedSparr0w@users.noreply.github.com>
Date: Sun, 12 Aug 2018 15:20:30 +1200
Subject: [PATCH] [GitHub] support issue tags with "/" character (#1902)
* support tags with "/" character
---
server.js | 2 +-
services/github/github.tester.js | 10 ++++++++++
2 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/server.js b/server.js
index 918ffccfe4..2cfcf1908a 100644
--- a/server.js
+++ b/server.js
@@ -3297,7 +3297,7 @@ cache(function(data, match, sendBadge, request) {
}));
// GitHub issues integration.
-camp.route(/^\/github\/issues(-pr)?(-closed)?(-raw)?\/([^/]+)\/([^/]+)\/?([^/]+)?\.(svg|png|gif|jpg|json)$/,
+camp.route(/^\/github\/issues(-pr)?(-closed)?(-raw)?\/(?!detail)([^/]+)\/([^/]+)\/?(.+)?\.(svg|png|gif|jpg|json)$/,
cache(function(data, match, sendBadge, request) {
var isPR = !!match[1];
var isClosed = !!match[2];
diff --git a/services/github/github.tester.js b/services/github/github.tester.js
index c0b4769878..24db265b50 100644
--- a/services/github/github.tester.js
+++ b/services/github/github.tester.js
@@ -211,6 +211,16 @@ t.create('GitHub open issues by label (raw)')
})
)
+// See #1870
+t.create('GitHub open issues by label including slash charactr (raw)')
+ .get('/issues-raw/IgorNovozhilov/ndk/@ndk/cfg.json')
+ .expectJSONTypes(
+ Joi.object().keys({
+ name: 'open @ndk/cfg issues',
+ value: isMetric,
+ })
+ )
+
t.create('GitHub open issues (repo not found)')
.get('/issues-raw/badges/helmets.json')
.expectJSON({
--
GitLab