From fdeda3e3f932c5fc3ff2150b54751c3fb3361604 Mon Sep 17 00:00:00 2001
From: chris48s <chris48s@users.noreply.github.com>
Date: Tue, 29 Aug 2023 19:57:42 +0100
Subject: [PATCH] Revert "log an error to sentry if an upstream service
responds with `429 Too Many Requests` (#9505)" (#9523)
This reverts commit 53537822de85a58fc9babe29a349edbc46590351.
---
core/base-service/check-error-response.js | 8 --------
core/base-service/check-error-response.spec.js | 2 +-
2 files changed, 1 insertion(+), 9 deletions(-)
diff --git a/core/base-service/check-error-response.js b/core/base-service/check-error-response.js
index 08753f6ecb..62b6b69577 100644
--- a/core/base-service/check-error-response.js
+++ b/core/base-service/check-error-response.js
@@ -1,4 +1,3 @@
-import log from '../server/log.js'
import { NotFound, InvalidResponse, Inaccessible } from './errors.js'
const defaultErrorMessages = {
@@ -26,13 +25,6 @@ export default function checkErrorResponse(httpErrors = {}) {
error = new InvalidResponse(props)
}
}
-
- if (res.statusCode === 429) {
- log.error(
- new Error(`429 Too Many Requests calling ${res.requestUrl.origin}`),
- )
- }
-
if (error) {
error.response = res
error.buffer = buffer
diff --git a/core/base-service/check-error-response.spec.js b/core/base-service/check-error-response.spec.js
index 411008dfd6..ba5d9a33e9 100644
--- a/core/base-service/check-error-response.spec.js
+++ b/core/base-service/check-error-response.spec.js
@@ -47,7 +47,7 @@ describe('async error handler', function () {
context('when status is 429', function () {
const buffer = Buffer.from('some stuff')
- const res = { statusCode: 429, requestUrl: new URL('https://example.com/') }
+ const res = { statusCode: 429 }
it('throws InvalidResponse', async function () {
try {
--
GitLab