Skip to content
Snippets Groups Projects
Commit 3fba5f4d authored by Abubakr-Sadik Nii Nai Davis's avatar Abubakr-Sadik Nii Nai Davis Committed by Liz Rice
Browse files

Fix version command failing because of missing config file it does not need. (#377)

* Fix version command failing because of missing config file it does
not need.

* Fix typo

* Remove reference to github issue in comment
parent 787bf6ca
No related branches found
No related tags found
No related merge requests found
......@@ -65,6 +65,12 @@ func NewRunFilter(opts FilterOpts) (check.Predicate, error) {
func runChecks(nodetype check.NodeType) {
var summary check.Summary
// Verify config file was loaded into Viper during Cobra sub-command initialization.
if configFileError != nil {
colorPrint(check.FAIL, fmt.Sprintf("Failed to read config file: %v\n", configFileError))
os.Exit(1)
}
def := loadConfig(nodetype)
in, err := ioutil.ReadFile(def)
if err != nil {
......
......@@ -49,6 +49,7 @@ var (
filterOpts FilterOpts
includeTestOutput bool
outputFile string
configFileError error
)
// RootCmd represents the base command when called without any subcommands
......@@ -134,7 +135,14 @@ func initConfig() {
// If a config file is found, read it in.
if err := viper.ReadInConfig(); err != nil {
colorPrint(check.FAIL, fmt.Sprintf("Failed to read config file: %v\n", err))
os.Exit(1)
if _, ok := err.(viper.ConfigFileNotFoundError); ok {
// Config file not found; ignore error for now to prevent commands
// which don't need the config file exiting.
configFileError = err
} else {
// Config file was found but another error was produced
colorPrint(check.FAIL, fmt.Sprintf("Failed to read config file: %v\n", err))
os.Exit(1)
}
}
}
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment