Skip to content
Snippets Groups Projects
Commit d12a45bb authored by Simarpreet Singh's avatar Simarpreet Singh Committed by Roberto Rojas
Browse files

Properly initialize viper library when checking for master components (#434)


* common_test: Add a failing test to show the SISEGV

Signed-off-by: default avatarSimarpreet Singh <simar@linux.com>

* common: Go green by fixing isMaster() to instantiate viper

Signed-off-by: default avatarSimarpreet Singh <simar@linux.com>

* common: Inject a seam for getBinariesFunc to be patched-in.

Also adds additional tests to showcase unhappy behaviors.

Signed-off-by: default avatarSimarpreet Singh <simar@linux.com>

* common_test: Rename TestIsMaster()

Signed-off-by: default avatarSimarpreet Singh <simar@linux.com>

* common: init viper with master config

Signed-off-by: default avatarSimarpreet Singh <simar@linux.com>

* common: Add a pre-check if valid yaml is passed but doesn't include master.

Also adds additional tests to showcase unhappy behaviors.

Signed-off-by: default avatarSimarpreet Singh <simar@linux.com>

* mod: Upgrade viper to v1.4.0

Signed-off-by: default avatarSimarpreet Singh <simar@linux.com>

* common: Refactor node only yaml to a file

Signed-off-by: default avatarSimarpreet Singh <simar@linux.com>

* common: Log  when master components are not found

Signed-off-by: default avatarSimarpreet Singh <simar@linux.com>

* common_test: Refactor subtests into a table

Signed-off-by: default avatarSimarpreet Singh <simar@linux.com>
parent a6ee61fd
No related branches found
No related tags found
No related merge requests found
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment