Skip to content
Snippets Groups Projects
  1. Oct 08, 2021
  2. Oct 07, 2021
  3. Oct 06, 2021
  4. Oct 05, 2021
  5. Oct 04, 2021
  6. Oct 03, 2021
  7. Oct 01, 2021
  8. Sep 30, 2021
  9. Sep 28, 2021
  10. Sep 27, 2021
  11. Sep 22, 2021
  12. Sep 21, 2021
  13. Sep 20, 2021
  14. Sep 18, 2021
  15. Sep 17, 2021
  16. Sep 16, 2021
    • Michael Bridgen's avatar
      Merge pull request #1828 from fluxcd/fail-manifests-build-properly · 0133caae
      Michael Bridgen authored
      Use a file to record successful manifests build
      0133caae
    • Michael Bridgen's avatar
      Use a file to record successful manifests build · 7ae4f289
      Michael Bridgen authored
      
      Using the directory cmd/flux/manifests as a prerequisite causes a
      problem: if the script that creates the files within fails, the next
      invocation of make will see the directory and assume it
      succeeded. Since the executable expects certain files to be present,
      but they are not explicit prerequisites of the recipe for building the
      binary, this results in a successful build but a broken `flux`
      executable.
      
      Instead, depend on a file that's explicitly updated when the script
      has succeeded, and which itself depends on the inputs.
      
      A couple of the CI workflows run
      
          make cmd/flux/manifests
      
      before doing other things, presumably as a way to avoid running the
      whole test suite in a CI pipeline for some purpose other than testing,
      so these needed changing as well.
      
      Signed-off-by: default avatarMichael Bridgen <michael@weave.works>
      7ae4f289
  17. Sep 13, 2021
Loading