Skip to content
Snippets Groups Projects
Unverified Commit c1a0111b authored by Tirumarai Selvan's avatar Tirumarai Selvan Committed by GitHub
Browse files

Merge pull request #88 from shahidhk/issue-83

close #83, prefix regsecret with remote name
parents f87df247 f9084954
No related branches found
No related tags found
No related merge requests found
...@@ -249,8 +249,7 @@ dockerRegistryPrompt: ...@@ -249,8 +249,7 @@ dockerRegistryPrompt:
if !skipRegistry { if !skipRegistry {
s := corev1.Secret{ s := corev1.Secret{
ObjectMeta: metav1.ObjectMeta{ ObjectMeta: metav1.ObjectMeta{
// TODO: handle secret name conflicts Name: o.Remote.GetName() + "-regsecret",
Name: "regsecret",
Namespace: o.Remote.GetNamespace(), Namespace: o.Remote.GetNamespace(),
}, },
Type: corev1.SecretTypeDockerConfigJson, Type: corev1.SecretTypeDockerConfigJson,
...@@ -284,7 +283,7 @@ dockerRegistryPrompt: ...@@ -284,7 +283,7 @@ dockerRegistryPrompt:
o.Remote.Spec.Registry = v1alpha1.RegistrySpec{ o.Remote.Spec.Registry = v1alpha1.RegistrySpec{
Url: fmt.Sprintf("%s/%s", registry, username), Url: fmt.Sprintf("%s/%s", registry, username),
Credentials: v1alpha1.CredentialsSpec{ Credentials: v1alpha1.CredentialsSpec{
SecretRef: "regsecret", SecretRef: o.Remote.GetName() + "-regsecret",
}, },
} }
} }
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment