Skip to content
Snippets Groups Projects
Commit ad93c8ba authored by David Morrison's avatar David Morrison
Browse files

log failure information

parent 8d608ac0
No related branches found
No related tags found
No related merge requests found
...@@ -479,7 +479,6 @@ func (m *asgCache) createPlaceholdersForDesiredNonStartedInstances(groups []*aut ...@@ -479,7 +479,6 @@ func (m *asgCache) createPlaceholdersForDesiredNonStartedInstances(groups []*aut
func (m *asgCache) isNodeGroupAvailable(group *autoscaling.Group) (bool, error) { func (m *asgCache) isNodeGroupAvailable(group *autoscaling.Group) (bool, error) {
input := &autoscaling.DescribeScalingActivitiesInput{ input := &autoscaling.DescribeScalingActivitiesInput{
AutoScalingGroupName: group.AutoScalingGroupName, AutoScalingGroupName: group.AutoScalingGroupName,
MaxRecords: aws.Int64(1), // We only care about the most recent event
} }
start := time.Now() start := time.Now()
...@@ -496,6 +495,7 @@ func (m *asgCache) isNodeGroupAvailable(group *autoscaling.Group) (bool, error) ...@@ -496,6 +495,7 @@ func (m *asgCache) isNodeGroupAvailable(group *autoscaling.Group) (bool, error)
if activity.StartTime.Before(lut) { if activity.StartTime.Before(lut) {
break break
} else if *activity.StatusCode == "Failed" { } else if *activity.StatusCode == "Failed" {
klog.Warningf("ASG %s scaling failed with %s", asgRef.Name, *activity)
return false, nil return false, nil
} }
} else { } else {
......
...@@ -128,7 +128,6 @@ func TestCreatePlaceholders(t *testing.T) { ...@@ -128,7 +128,6 @@ func TestCreatePlaceholders(t *testing.T) {
if shouldCallDescribeScalingActivities { if shouldCallDescribeScalingActivities {
a.On("DescribeScalingActivities", &autoscaling.DescribeScalingActivitiesInput{ a.On("DescribeScalingActivities", &autoscaling.DescribeScalingActivitiesInput{
AutoScalingGroupName: asgName, AutoScalingGroupName: asgName,
MaxRecords: aws.Int64(1),
}).Return( }).Return(
&autoscaling.DescribeScalingActivitiesOutput{Activities: tc.activities}, &autoscaling.DescribeScalingActivitiesOutput{Activities: tc.activities},
tc.describeErr, tc.describeErr,
......
...@@ -466,7 +466,6 @@ func TestDeleteNodesWithPlaceholder(t *testing.T) { ...@@ -466,7 +466,6 @@ func TestDeleteNodesWithPlaceholder(t *testing.T) {
a.On("DescribeScalingActivities", a.On("DescribeScalingActivities",
&autoscaling.DescribeScalingActivitiesInput{ &autoscaling.DescribeScalingActivitiesInput{
AutoScalingGroupName: aws.String("test-asg"), AutoScalingGroupName: aws.String("test-asg"),
MaxRecords: aws.Int64(1),
}, },
).Return(&autoscaling.DescribeScalingActivitiesOutput{}, nil) ).Return(&autoscaling.DescribeScalingActivitiesOutput{}, nil)
......
...@@ -394,7 +394,6 @@ func TestFetchExplicitAsgs(t *testing.T) { ...@@ -394,7 +394,6 @@ func TestFetchExplicitAsgs(t *testing.T) {
a.On("DescribeScalingActivities", a.On("DescribeScalingActivities",
&autoscaling.DescribeScalingActivitiesInput{ &autoscaling.DescribeScalingActivitiesInput{
AutoScalingGroupName: aws.String("coolasg"), AutoScalingGroupName: aws.String("coolasg"),
MaxRecords: aws.Int64(1),
}, },
).Return(&autoscaling.DescribeScalingActivitiesOutput{}, nil) ).Return(&autoscaling.DescribeScalingActivitiesOutput{}, nil)
...@@ -559,7 +558,6 @@ func TestFetchAutoAsgs(t *testing.T) { ...@@ -559,7 +558,6 @@ func TestFetchAutoAsgs(t *testing.T) {
a.On("DescribeScalingActivities", a.On("DescribeScalingActivities",
&autoscaling.DescribeScalingActivitiesInput{ &autoscaling.DescribeScalingActivitiesInput{
AutoScalingGroupName: aws.String("coolasg"), AutoScalingGroupName: aws.String("coolasg"),
MaxRecords: aws.Int64(1),
}, },
).Return(&autoscaling.DescribeScalingActivitiesOutput{}, nil) ).Return(&autoscaling.DescribeScalingActivitiesOutput{}, nil)
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment