-
- Downloads
MatrixRTC: Rename `MembershipConfig` parameters (#4714)
* Remove redundant sendDelayedEventAction We do already have the state `hasMemberEvent` that allows to distinguish the two cases. No need to create two dedicated actions. * fix missing return * Make membership manager an event emitter to inform about status updates. - deprecate isJoined (replaced by isActivated) - move Interface types to types.ts * add tests for status updates. * lint * test "reschedules delayed leave event" in case the delayed event gets canceled * review * fix types * prettier * fix legacy membership manager * remove deprecated jitter. * use non deprecated config fields (keep deprecated fields as fallback) * update tests to test non deprecated names * make local NewMembershipManager variable names consistent with config * make LegacyMembershipManger local variables consistent with config * comments and rename `networkErrorLocalRetryMs` -> `networkErrorRetryMs` * review
Showing
- spec/unit/matrixrtc/MatrixRTCSession.spec.ts 2 additions, 2 deletionsspec/unit/matrixrtc/MatrixRTCSession.spec.ts
- spec/unit/matrixrtc/MembershipManager.spec.ts 9 additions, 9 deletionsspec/unit/matrixrtc/MembershipManager.spec.ts
- src/matrixrtc/LegacyMembershipManager.ts 21 additions, 19 deletionssrc/matrixrtc/LegacyMembershipManager.ts
- src/matrixrtc/MatrixRTCSession.ts 23 additions, 18 deletionssrc/matrixrtc/MatrixRTCSession.ts
- src/matrixrtc/NewMembershipManager.ts 30 additions, 25 deletionssrc/matrixrtc/NewMembershipManager.ts
Loading
Please register or sign in to comment