Skip to content
Snippets Groups Projects
Unverified Commit f16277e8 authored by Arunprasad Rajkumar's avatar Arunprasad Rajkumar
Browse files

Sanitize regex denylist in ksm-lite addon


The following metrics are missing from kube-state-metrics:
- kube_pod_container_status_terminated_reason
- kube_pod_init_container_status_terminated_reason
- kube_pod_status_scheduled_time

Previously, some metrics were removed from kube-state-metrics by adding the following --metric-denylist argument to the kube-state-metrics container

```
--metric-denylist=
kube_.+_created,
kube_.+_metadata_resource_version,
kube_replicaset_metadata_generation,
kube_replicaset_status_observed_generation,
kube_pod_restart_policy,
kube_pod_init_container_status_terminated,
kube_pod_init_container_status_running,
kube_pod_container_status_terminated,
kube_pod_container_status_running,
kube_pod_completion_time,
kube_pod_status_scheduled
```

--metric-denylist: Comma-separated list of metrics not to be enabled. This list comprises of exact metric names and/or regex patterns. The allowlist and denylist are mutually exclusive.

However, all the list of metrics is managed as RegEx, thus "kube_pod_container_status_terminated" denies .*kube_pod_container_status_terminated.*, that's why kube_pod_init_container_status_terminated_reason is missing

Co-authored-by: default avatarFlorian Gleizes <fgleizes@redhat.com>
Signed-off-by: default avatarArunprasad Rajkumar <arajkuma@redhat.com>
parent 755d27bb
No related branches found
No related tags found
No related merge requests found
...@@ -21,12 +21,12 @@ local addArgs(args, name, containers) = std.map( ...@@ -21,12 +21,12 @@ local addArgs(args, name, containers) = std.map(
kube_replicaset_metadata_generation, kube_replicaset_metadata_generation,
kube_replicaset_status_observed_generation, kube_replicaset_status_observed_generation,
kube_pod_restart_policy, kube_pod_restart_policy,
kube_pod_init_container_status_terminated, kube_pod_init_container_status_terminated$,
kube_pod_init_container_status_running, kube_pod_init_container_status_running,
kube_pod_container_status_terminated, kube_pod_container_status_terminated$,
kube_pod_container_status_running, kube_pod_container_status_running,
kube_pod_completion_time, kube_pod_completion_time,
kube_pod_status_scheduled kube_pod_status_scheduled$
|||], |||],
'kube-state-metrics', 'kube-state-metrics',
super.containers super.containers
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment