Skip to content
Snippets Groups Projects
Unverified Commit 08de7aff authored by Rhys Arkins's avatar Rhys Arkins Committed by GitHub
Browse files

fix(npm): replace all instances of $NPM_TOKEN in npmrc (#6431)

parent a23562a8
No related merge requests found
...@@ -36,7 +36,8 @@ describe('config/decrypt', () => { ...@@ -36,7 +36,8 @@ describe('config/decrypt', () => {
}); });
it('replaces npm token placeholder in npmrc', () => { it('replaces npm token placeholder in npmrc', () => {
config.privateKey = privateKey; config.privateKey = privateKey;
config.npmrc = '//registry.npmjs.org/:_authToken=${NPM_TOKEN}\n'; // eslint-disable-line no-template-curly-in-string config.npmrc =
'//registry.npmjs.org/:_authToken=${NPM_TOKEN}\n//registry.npmjs.org/:_authToken=${NPM_TOKEN}\n'; // eslint-disable-line no-template-curly-in-string
config.encrypted = { config.encrypted = {
npmToken: npmToken:
'FLA9YHIzpE7YetAg/P0X46npGRCMqn7hgyzwX5ZQ9wYgu9BRRbTiBVsUIFTyM5BuP1Q22slT2GkWvFvum7GU236Y6QiT7Nr8SLvtsJn2XUuq8H7REFKzdy3+wqyyWbCErYTFyY1dcPM7Ht+CaGDWdd8u/FsoX7AdMRs/X1jNUo6iSmlUiyGlYDKF+QMnCJom1VPVgZXWsGKdjI2MLny991QMaiv0VajmFIh4ENv4CtXOl/1twvIl/6XTXAaqpJJKDTPZEuydi+PHDZmal2RAOfrkH4m0UURa7SlfpUlIg+EaqbNGp85hCYXLwRcEET1OnYr3rH1oYkcYJ40any1tvQ==', 'FLA9YHIzpE7YetAg/P0X46npGRCMqn7hgyzwX5ZQ9wYgu9BRRbTiBVsUIFTyM5BuP1Q22slT2GkWvFvum7GU236Y6QiT7Nr8SLvtsJn2XUuq8H7REFKzdy3+wqyyWbCErYTFyY1dcPM7Ht+CaGDWdd8u/FsoX7AdMRs/X1jNUo6iSmlUiyGlYDKF+QMnCJom1VPVgZXWsGKdjI2MLny991QMaiv0VajmFIh4ENv4CtXOl/1twvIl/6XTXAaqpJJKDTPZEuydi+PHDZmal2RAOfrkH4m0UURa7SlfpUlIg+EaqbNGp85hCYXLwRcEET1OnYr3rH1oYkcYJ40any1tvQ==',
...@@ -45,7 +46,7 @@ describe('config/decrypt', () => { ...@@ -45,7 +46,7 @@ describe('config/decrypt', () => {
expect(res.encrypted).not.toBeDefined(); expect(res.encrypted).not.toBeDefined();
expect(res.npmToken).not.toBeDefined(); expect(res.npmToken).not.toBeDefined();
expect(res.npmrc).toEqual( expect(res.npmrc).toEqual(
'//registry.npmjs.org/:_authToken=abcdef-ghijklm-nopqf-stuvwxyz\n' '//registry.npmjs.org/:_authToken=abcdef-ghijklm-nopqf-stuvwxyz\n//registry.npmjs.org/:_authToken=abcdef-ghijklm-nopqf-stuvwxyz\n'
); );
}); });
it('appends npm token in npmrc', () => { it('appends npm token in npmrc', () => {
......
...@@ -54,7 +54,7 @@ export function decryptConfig( ...@@ -54,7 +54,7 @@ export function decryptConfig(
if (decryptedConfig.npmrc.includes('${NPM_TOKEN}')) { if (decryptedConfig.npmrc.includes('${NPM_TOKEN}')) {
logger.debug('Replacing ${NPM_TOKEN} with decrypted token'); logger.debug('Replacing ${NPM_TOKEN} with decrypted token');
decryptedConfig.npmrc = decryptedConfig.npmrc.replace( decryptedConfig.npmrc = decryptedConfig.npmrc.replace(
'${NPM_TOKEN}', /\${NPM_TOKEN}/g,
token token
); );
} else { } else {
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment