Skip to content
Snippets Groups Projects
Unverified Commit 0af1be57 authored by Maksim's avatar Maksim Committed by GitHub
Browse files

refactor(migrations): ignoreNpmrcFile (#14802)

parent e35a0e29
No related branches found
No related tags found
No related merge requests found
...@@ -122,11 +122,6 @@ export function migrateConfig( ...@@ -122,11 +122,6 @@ export function migrateConfig(
regEx(/{{depNameShort}}/g), regEx(/{{depNameShort}}/g),
'{{depName}}' '{{depName}}'
); );
} else if (key === 'ignoreNpmrcFile') {
delete migratedConfig.ignoreNpmrcFile;
if (!is.string(migratedConfig.npmrc)) {
migratedConfig.npmrc = '';
}
} else if ( } else if (
key === 'branchPrefix' && key === 'branchPrefix' &&
is.string(val) && is.string(val) &&
......
import { IgnoreNpmrcFileMigration } from './ignore-npmrc-file-migration';
describe('config/migrations/custom/ignore-npmrc-file-migration', () => {
it('should init npmrc field', () => {
expect(IgnoreNpmrcFileMigration).toMigrate(
{
ignoreNpmrcFile: true,
},
{
npmrc: '',
}
);
});
it('should not change npmrc field if it represents string value', () => {
expect(IgnoreNpmrcFileMigration).toMigrate(
{
ignoreNpmrcFile: true,
npmrc: '',
},
{
npmrc: '',
}
);
});
it('should change npmrc field if it not represents string value', () => {
expect(IgnoreNpmrcFileMigration).toMigrate(
{
ignoreNpmrcFile: true,
npmrc: true,
} as any,
{
npmrc: '',
}
);
});
});
import is from '@sindresorhus/is';
import { AbstractMigration } from '../base/abstract-migration';
export class IgnoreNpmrcFileMigration extends AbstractMigration {
override readonly deprecated = true;
override readonly propertyName = 'ignoreNpmrcFile';
override run(): void {
const npmrc = this.get('npmrc');
if (!is.string(npmrc)) {
this.setHard('npmrc', '');
}
}
}
...@@ -16,6 +16,7 @@ import { EnabledManagersMigration } from './custom/enabled-managers-migration'; ...@@ -16,6 +16,7 @@ import { EnabledManagersMigration } from './custom/enabled-managers-migration';
import { GoModTidyMigration } from './custom/go-mod-tidy-migration'; import { GoModTidyMigration } from './custom/go-mod-tidy-migration';
import { HostRulesMigration } from './custom/host-rules-migration'; import { HostRulesMigration } from './custom/host-rules-migration';
import { IgnoreNodeModulesMigration } from './custom/ignore-node-modules-migration'; import { IgnoreNodeModulesMigration } from './custom/ignore-node-modules-migration';
import { IgnoreNpmrcFileMigration } from './custom/ignore-npmrc-file-migration';
import { PackageNameMigration } from './custom/package-name-migration'; import { PackageNameMigration } from './custom/package-name-migration';
import { PackagePatternMigration } from './custom/package-pattern-migration'; import { PackagePatternMigration } from './custom/package-pattern-migration';
import { PackagesMigration } from './custom/packages-migration'; import { PackagesMigration } from './custom/packages-migration';
...@@ -78,6 +79,7 @@ export class MigrationsService { ...@@ -78,6 +79,7 @@ export class MigrationsService {
GoModTidyMigration, GoModTidyMigration,
HostRulesMigration, HostRulesMigration,
IgnoreNodeModulesMigration, IgnoreNodeModulesMigration,
IgnoreNpmrcFileMigration,
PackageNameMigration, PackageNameMigration,
PackagePatternMigration, PackagePatternMigration,
PackagesMigration, PackagesMigration,
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment