Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
renovate
Manage
Activity
Members
Code
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Deploy
Releases
Model registry
Analyze
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
GitHub Mirror
Renovate Bot
renovate
Commits
0f1ccb77
Commit
0f1ccb77
authored
4 years ago
by
Rhys Arkins
Browse files
Options
Downloads
Patches
Plain Diff
test: replace coverage fix todo
parent
8b97c924
No related branches found
No related tags found
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
lib/manager/npm/update/locked-dependency/parent-version.spec.ts
+22
-0
22 additions, 0 deletions
...nager/npm/update/locked-dependency/parent-version.spec.ts
lib/manager/npm/update/locked-dependency/parent-version.ts
+0
-1
0 additions, 1 deletion
lib/manager/npm/update/locked-dependency/parent-version.ts
with
22 additions
and
1 deletion
lib/manager/npm/update/locked-dependency/parent-version.spec.ts
+
22
−
0
View file @
0f1ccb77
...
...
@@ -65,6 +65,28 @@ describe(getName(__filename), () => {
)
).
toEqual
(
'
4.9.1
'
);
});
it
(
'
finds when a greater version is needed
'
,
async
()
=>
{
httpMock
.
scope
(
'
https://registry.npmjs.org
'
)
.
get
(
'
/qs
'
)
.
reply
(
200
,
{
name
:
'
qs
'
,
repository
:
{},
versions
:
{
'
0.6.6
'
:
{},
'
6.0.4
'
:
{},
'
6.2.0
'
:
{},
},
'
dist-tags
'
:
{
latest
:
'
6.2.0
'
},
});
httpMock
.
scope
(
'
https://registry.npmjs.org
'
)
.
get
(
'
/express
'
)
.
reply
(
200
,
expressJson
);
expect
(
await
findFirstParentVersion
(
'
express
'
,
'
4.0.0
'
,
'
qs
'
,
'
6.0.4
'
)
).
toEqual
(
'
4.14.0
'
);
});
it
(
'
finds when a range matches greater versions
'
,
async
()
=>
{
httpMock
.
scope
(
'
https://registry.npmjs.org
'
)
...
...
This diff is collapsed.
Click to expand it.
lib/manager/npm/update/locked-dependency/parent-version.ts
+
0
−
1
View file @
0f1ccb77
...
...
@@ -64,7 +64,6 @@ export async function findFirstParentVersion(
return
parentVersion
;
}
if
(
semver
.
isVersion
(
constraint
))
{
// istanbul ignore if: TODO FIX ME
if
(
semver
.
isGreaterThan
(
constraint
,
targetVersion
))
{
// it's not the version we were after - the parent skipped to a higher version
logger
.
debug
(
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment