Skip to content
Snippets Groups Projects
Commit 286ab6dc authored by Rhys Arkins's avatar Rhys Arkins
Browse files

refactor: rename getReleases -> getInRangeReleases

parent 3f277390
No related branches found
No related tags found
No related merge requests found
import { logger } from '../../../logger'; import { logger } from '../../../logger';
import * as allVersioning from '../../../versioning'; import * as allVersioning from '../../../versioning';
import * as sourceGithub from './source-github'; import * as sourceGithub from './source-github';
import { getReleases } from './releases'; import { getInRangeReleases } from './releases';
import { ChangeLogConfig, ChangeLogResult } from './common'; import { ChangeLogConfig, ChangeLogResult } from './common';
export * from './common'; export * from './common';
...@@ -18,7 +18,7 @@ export async function getChangeLogJSON( ...@@ -18,7 +18,7 @@ export async function getChangeLogJSON(
return null; return null;
} }
const releases = args.releases || (await getReleases(args)); const releases = args.releases || (await getInRangeReleases(args));
try { try {
const res = await sourceGithub.getChangeLogJSON({ ...args, releases }); const res = await sourceGithub.getChangeLogJSON({ ...args, releases });
......
...@@ -25,7 +25,7 @@ export type ReleaseConfig = PkgReleaseConfig & { ...@@ -25,7 +25,7 @@ export type ReleaseConfig = PkgReleaseConfig & {
toVersion: string; toVersion: string;
}; };
export async function getReleases( export async function getInRangeReleases(
config: ReleaseConfig config: ReleaseConfig
): Promise<Release[] | null> { ): Promise<Release[] | null> {
const { versioning, fromVersion, toVersion, depName, datasource } = config; const { versioning, fromVersion, toVersion, depName, datasource } = config;
...@@ -54,7 +54,7 @@ export async function getReleases( ...@@ -54,7 +54,7 @@ export async function getReleases(
} }
return releases; return releases;
} catch (err) /* istanbul ignore next */ { } catch (err) /* istanbul ignore next */ {
logger.debug({ err }, 'getReleases err'); logger.debug({ err }, 'getInRangeReleases err');
logger.debug({ datasource, depName }, 'Error getting releases'); logger.debug({ datasource, depName }, 'Error getting releases');
return null; return null;
} }
......
...@@ -46,7 +46,7 @@ describe('workers/pr/changelog/releases', () => { ...@@ -46,7 +46,7 @@ describe('workers/pr/changelog/releases', () => {
fromVersion: '1.0.0', fromVersion: '1.0.0',
toVersion: '1.1.0', toVersion: '1.1.0',
}; };
const res = await releases.getReleases(config); const res = await releases.getInRangeReleases(config);
expect(res).toMatchSnapshot(); expect(res).toMatchSnapshot();
expect(res).toHaveLength(3); expect(res).toHaveLength(3);
}); });
...@@ -56,7 +56,7 @@ describe('workers/pr/changelog/releases', () => { ...@@ -56,7 +56,7 @@ describe('workers/pr/changelog/releases', () => {
fromVersion: '1.0.1-rc0', fromVersion: '1.0.1-rc0',
toVersion: '1.1.0', toVersion: '1.1.0',
}; };
const res = await releases.getReleases(config); const res = await releases.getInRangeReleases(config);
expect(res).toMatchSnapshot(); expect(res).toMatchSnapshot();
expect(res).toHaveLength(4); expect(res).toHaveLength(4);
}); });
...@@ -66,7 +66,7 @@ describe('workers/pr/changelog/releases', () => { ...@@ -66,7 +66,7 @@ describe('workers/pr/changelog/releases', () => {
fromVersion: '1.0.1', fromVersion: '1.0.1',
toVersion: '1.2.0-rc1', toVersion: '1.2.0-rc1',
}; };
const res = await releases.getReleases(config); const res = await releases.getInRangeReleases(config);
expect(res).toMatchSnapshot(); expect(res).toMatchSnapshot();
expect(res).toHaveLength(4); expect(res).toHaveLength(4);
}); });
...@@ -76,7 +76,7 @@ describe('workers/pr/changelog/releases', () => { ...@@ -76,7 +76,7 @@ describe('workers/pr/changelog/releases', () => {
fromVersion: '1.0.1-rc0', fromVersion: '1.0.1-rc0',
toVersion: '1.2.0-rc1', toVersion: '1.2.0-rc1',
}; };
const res = await releases.getReleases(config); const res = await releases.getInRangeReleases(config);
expect(res).toMatchSnapshot(); expect(res).toMatchSnapshot();
expect(res).toHaveLength(6); expect(res).toHaveLength(6);
}); });
...@@ -86,7 +86,7 @@ describe('workers/pr/changelog/releases', () => { ...@@ -86,7 +86,7 @@ describe('workers/pr/changelog/releases', () => {
fromVersion: '1.0.1-rc0', fromVersion: '1.0.1-rc0',
toVersion: '1.2.0-rc0', toVersion: '1.2.0-rc0',
}; };
const res = await releases.getReleases(config); const res = await releases.getInRangeReleases(config);
expect(res).toMatchSnapshot(); expect(res).toMatchSnapshot();
expect(res).toHaveLength(3); expect(res).toHaveLength(3);
}); });
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment