Skip to content
Snippets Groups Projects
Unverified Commit 2d9734c3 authored by jose-ws's avatar jose-ws Committed by GitHub
Browse files

feat(proxy): proxy environment variables available in lowercase for child processes. (#9978)

parent f28d98fb
No related branches found
No related tags found
No related merge requests found
......@@ -7,7 +7,9 @@ describe('proxy', () => {
beforeEach(() => {
delete process.env.HTTP_PROXY;
delete process.env.http_proxy;
delete process.env.HTTPS_PROXY;
delete process.env.https_proxy;
delete process.env.NO_PROXY;
delete process.env.no_proxy;
});
......@@ -17,11 +19,35 @@ describe('proxy', () => {
bootstrap();
expect(hasProxy()).toBeTrue();
});
it('copies upper case HTTP_PROXY to http_proxy', () => {
process.env.HTTP_PROXY = httpProxy;
bootstrap();
expect(hasProxy()).toBeTrue();
expect(process.env.HTTP_PROXY).toBeDefined();
expect(process.env.http_proxy).toBeDefined();
expect(process.env.HTTPS_PROXY).toBeUndefined();
expect(process.env.https_proxy).toBeUndefined();
expect(process.env.NO_PROXY).toBeUndefined();
expect(process.env.no_proxy).toBeUndefined();
});
it('respects HTTPS_PROXY', () => {
process.env.HTTPS_PROXY = httpsProxy;
bootstrap();
expect(hasProxy()).toBeTrue();
});
it('copies upper case HTTPS_PROXY to https_proxy', () => {
process.env.HTTPS_PROXY = httpsProxy;
bootstrap();
expect(hasProxy()).toBeTrue();
expect(process.env.HTTPS_PROXY).toBeDefined();
expect(process.env.https_proxy).toBeDefined();
expect(process.env.HTTP_PROXY).toBeUndefined();
expect(process.env.http_proxy).toBeUndefined();
expect(process.env.NO_PROXY).toBeUndefined();
expect(process.env.no_proxy).toBeUndefined();
});
it('does nothing', () => {
process.env.no_proxy = noProxy;
bootstrap();
......
......@@ -14,6 +14,10 @@ export function bootstrap(): void {
) {
process.env[envVar] = process.env[envVar.toLowerCase()];
}
if (process.env[envVar]) {
process.env[envVar.toLowerCase()] = process.env[envVar];
}
});
if (
......
......@@ -4,6 +4,9 @@ const basicEnvVars = [
'HTTP_PROXY',
'HTTPS_PROXY',
'NO_PROXY',
'http_proxy',
'https_proxy',
'no_proxy',
'HOME',
'PATH',
'LC_ALL',
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment