refactor: set recreateClosed in group and lockFileMaintenance

lib/config/definitions.js

@@ -262,6 +262,7 @@ const options = [
     type: 'json',
     default: {
       enabled: true,
+      recreateClosed: true,
       branchName: 'renovate/lock-files',
       commitMessage: '{{semanticPrefix}}Update lock file',
       prTitle: '{{semanticPrefix}}Lock file maintenance',
@@ -301,6 +302,7 @@ const options = [
     description: 'Config if groupName is enabled',
     type: 'json',
     default: {
+      recreateClosed: true,
       branchName: template('branchName', 'group'),
       commitMessage: template('commitMessage', 'group'),
       prTitle: template('prTitle', 'group'),

lib/workers/branch/index.js

@@ -221,9 +221,8 @@ async function updateBranch(upgrades) {
 
   try {
     if (
-      upgrade0.upgradeType !== 'lockFileMaintenance' &&
-      upgrade0.groupName === null &&
-      !upgrade0.recreateClosed &&
+      // Groups and lock file maintenance should set this to true
+      upgrade0.recreateClosed === false &&
       (await upgrade0.api.checkForClosedPr(branchName, prTitle))
     ) {
       logger.info(`Skipping branch as matching closed PR already existed`);

test/config/__snapshots__/index.spec.js.snap

@@ -7,6 +7,7 @@ Object {
   "enabled": true,
   "prBody": "This PR regenerates lock files to keep them up-to-date.",
   "prTitle": "{{semanticPrefix}}Lock file maintenance",
+  "recreateClosed": true,
   "schedule": "on monday",
 }
 `;