refactor: move getRangeStrategy to manager (#2072)

lib/manager/index.js

@@ -44,3 +44,16 @@ for (const f of managerFunctions) {
     return null;
   };
 }
+
+module.exports.getRangeStrategy = config => {
+  const { manager, rangeStrategy } = config;
+  if (managers[manager].getRangeStrategy) {
+    // Use manager's own function if it exists
+    return managers[manager].getRangeStrategy(config);
+  }
+  if (rangeStrategy === 'auto') {
+    // default to 'replace' for auto
+    return 'replace';
+  }
+  return config.rangeStrategy;
+};

lib/manager/npm/index.js

 const { extractDependencies, postExtract } = require('./extract');
 const { updateDependency } = require('./update');
+const { getRangeStrategy } = require('./range');
 
 module.exports = {
   extractDependencies,
   postExtract,
+  getRangeStrategy,
   updateDependency,
   supportsLockFileMaintenance: true,
 };

lib/workers/repository/process/lookup/index.js

 const versioning = require('../../../../versioning/semver');
 const moment = require('moment');
 const { getRollbackUpdate } = require('./rollback');
-const { getRangeStrategy } = require('./range');
+const { getRangeStrategy } = require('../../../../manager');
 const { filterVersions } = require('./filter');
 const npmApi = require('../../../../datasource/npm');
 const github = require('../../../../datasource/github');

test/workers/repository/process/lookup/range.spec.js → test/manager/npm/range.spec.js

-const {
-  getRangeStrategy,
-} = require('../../../../../lib/workers/repository/process/lookup/range');
+const { getRangeStrategy } = require('../../../lib/manager/npm');
 
 describe('getRangeStrategy', () => {
   it('returns same if not auto', () => {

test/manager/range.spec.js

+const { getRangeStrategy } = require('../../lib/manager');
+
+describe('getRangeStrategy', () => {
+  it('returns same if not auto', () => {
+    const config = { manager: 'npm', rangeStrategy: 'widen' };
+    expect(getRangeStrategy(config)).toEqual('widen');
+  });
+  it('returns manager strategy', () => {
+    const config = {
+      manager: 'npm',
+      rangeStrategy: 'auto',
+      depType: 'dependencies',
+      packageJsonType: 'app',
+    };
+    expect(getRangeStrategy(config)).toEqual('pin');
+  });
+  it('defaults to replace', () => {
+    const config = { manager: 'circleci', rangeStrategy: 'auto' };
+    expect(getRangeStrategy(config)).toEqual('replace');
+  });
+  it('returns rangeStrategy if not auto', () => {
+    const config = { manager: 'circleci', rangeStrategy: 'future' };
+    expect(getRangeStrategy(config)).toEqual('future');
+  });
+});

test/workers/repository/process/lookup/index.spec.js

@@ -15,6 +15,7 @@ let config;
 describe('manager/npm/lookup', () => {
   beforeEach(() => {
     config = { ...require('../../../../../lib/config/defaults').getConfig() };
+    config.manager = 'npm';
     config.rangeStrategy = 'replace';
     jest.resetAllMocks();
   });