Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
renovate
Manage
Activity
Members
Code
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Deploy
Releases
Model registry
Analyze
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
GitHub Mirror
Renovate Bot
renovate
Commits
66b82aca
Unverified
Commit
66b82aca
authored
1 year ago
by
Sergei Zharinov
Committed by
GitHub
1 year ago
Browse files
Options
Downloads
Patches
Plain Diff
ci: Fix `test-success` job condition (#22853)
parent
6ac3292c
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
.github/workflows/build.yml
+20
-12
20 additions, 12 deletions
.github/workflows/build.yml
with
20 additions
and
12 deletions
.github/workflows/build.yml
+
20
−
12
View file @
66b82aca
...
...
@@ -375,22 +375,30 @@ jobs:
timeout-minutes
:
1
if
:
always()
steps
:
-
if
:
|
-
name
:
Fail for failed or cancelled tests
if
:
|
needs.test.result == 'failure' ||
needs.test.result == 'cancelled' ||
(needs.test.result == 'skipped' &&
!(github.event.pull_request.draft &&
needs.setup.outputs.test-matrix-empty == 'true')
)
needs.test.result == 'cancelled'
run
:
exit
1
-
if
:
|
-
name
:
Fail for skipped tests when PR is ready for review
if
:
|
github.event_name == 'pull_request' &&
github.event.pull_request.draft != true &&
needs.test.result == 'skipped'
run
:
exit
1
-
name
:
Fail for failed or cancelled coverage
if
:
|
needs.coverage.result == 'failure' ||
needs.coverage.result == 'cancelled' ||
(needs.coverage.result == 'skipped' &&
!(github.event.pull_request.draft &&
needs.setup.outputs.test-matrix-empty == 'true')
)
needs.coverage.result == 'cancelled'
run
:
exit
1
-
name
:
Fail for skipped coverage when PR is ready for review
if
:
|
github.event_name == 'pull_request' &&
github.event.pull_request.draft != true &&
needs.coverage.result == 'skipped'
run
:
exit
1
build
:
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment