fix: increase prNotPendingHours default to 24 hours (#1316)

To prevent PRs being opened prior to the `unpublishSafe` check having
transitioned from `pending` to `success`, when using `not-pending`
mode.

Fixes #1312.

docs/configuration.md

@@ -609,7 +609,7 @@ location with this method.
   <td>`prNotPendingHours`</td>
   <td>Timeout in hours for when prCreation=not-pending</td>
   <td>integer</td>
-  <td><pre>12</pre></td>
+  <td><pre>24</pre></td>
   <td>`RENOVATE_PR_NOT_PENDING_HOURS`</td>
   <td>`--pr-not-pending-hours`<td>
 </tr>

lib/config/definitions.js

@@ -495,7 +495,8 @@ const options = [
     name: 'prNotPendingHours',
     description: 'Timeout in hours for when prCreation=not-pending',
     type: 'integer',
-    default: 12,
+    // Must be at least 24 hours to give time for the unpublishSafe check to "complete".
+    default: 24,
   },
   // Automatic merging
   {

test/manager/__snapshots__/resolve.spec.js.snap

@@ -502,7 +502,7 @@ Please make sure the following warnings are safe to ignore:
 
 This PR has been generated by [Renovate Bot](https://renovateapp.com).",
   "prCreation": "immediate",
-  "prNotPendingHours": 12,
+  "prNotPendingHours": 24,
   "prTitle": "{{#if isPin}}Pin{{else}}{{#if isRollback}}Roll back{{else}}Update{{/if}}{{/if}} dependency {{depName}} to {{#if isRange}}{{newVersion}}{{else}}{{#if isMajor}}v{{newVersionMajor}}{{else}}v{{newVersion}}{{/if}}{{/if}}",
   "privateKey": null,
   "rebaseStalePrs": false,
@@ -1040,7 +1040,7 @@ Please make sure the following warnings are safe to ignore:
 
 This PR has been generated by [Renovate Bot](https://renovateapp.com).",
   "prCreation": "immediate",
-  "prNotPendingHours": 12,
+  "prNotPendingHours": 24,
   "prTitle": "{{#if isPin}}Pin{{else}}{{#if isRollback}}Roll back{{else}}Update{{/if}}{{/if}} dependency {{depName}} to {{#if isRange}}{{newVersion}}{{else}}{{#if isMajor}}v{{newVersionMajor}}{{else}}v{{newVersion}}{{/if}}{{/if}}",
   "privateKey": null,
   "rebaseStalePrs": false,
@@ -1834,7 +1834,7 @@ Please make sure the following warnings are safe to ignore:
 
 This PR has been generated by [Renovate Bot](https://renovateapp.com).",
   "prCreation": "immediate",
-  "prNotPendingHours": 12,
+  "prNotPendingHours": 24,
   "prTitle": "{{#if isPin}}Pin{{else}}{{#if isRollback}}Roll back{{else}}Update{{/if}}{{/if}} dependency {{depName}} to {{#if isRange}}{{newVersion}}{{else}}{{#if isMajor}}v{{newVersionMajor}}{{else}}v{{newVersion}}{{/if}}{{/if}}",
   "privateKey": null,
   "rebaseStalePrs": false,
@@ -2367,7 +2367,7 @@ Please make sure the following warnings are safe to ignore:
 
 This PR has been generated by [Renovate Bot](https://renovateapp.com).",
   "prCreation": "immediate",
-  "prNotPendingHours": 12,
+  "prNotPendingHours": 24,
   "prTitle": "{{#if isPin}}Pin{{else}}{{#if isRollback}}Roll back{{else}}Update{{/if}}{{/if}} dependency {{depName}} to {{#if isRange}}{{newVersion}}{{else}}{{#if isMajor}}v{{newVersionMajor}}{{else}}v{{newVersion}}{{/if}}{{/if}}",
   "privateKey": null,
   "rebaseStalePrs": false,
@@ -2891,7 +2891,7 @@ Please make sure the following warnings are safe to ignore:
 
 This PR has been generated by [Renovate Bot](https://renovateapp.com).",
   "prCreation": "immediate",
-  "prNotPendingHours": 12,
+  "prNotPendingHours": 24,
   "prTitle": "{{#if isPin}}Pin{{else}}{{#if isRollback}}Roll back{{else}}Update{{/if}}{{/if}} dependency {{depName}} to {{#if isRange}}{{newVersion}}{{else}}{{#if isMajor}}v{{newVersionMajor}}{{else}}v{{newVersion}}{{/if}}{{/if}}",
   "privateKey": null,
   "rebaseStalePrs": false,
@@ -3415,7 +3415,7 @@ Please make sure the following warnings are safe to ignore:
 
 This PR has been generated by [Renovate Bot](https://renovateapp.com).",
   "prCreation": "immediate",
-  "prNotPendingHours": 12,
+  "prNotPendingHours": 24,
   "prTitle": "{{#if isPin}}Pin{{else}}{{#if isRollback}}Roll back{{else}}Update{{/if}}{{/if}} dependency {{depName}} to {{#if isRange}}{{newVersion}}{{else}}{{#if isMajor}}v{{newVersionMajor}}{{else}}v{{newVersion}}{{/if}}{{/if}}",
   "privateKey": null,
   "rebaseStalePrs": false,
@@ -3948,7 +3948,7 @@ Please make sure the following warnings are safe to ignore:
 
 This PR has been generated by [Renovate Bot](https://renovateapp.com).",
   "prCreation": "immediate",
-  "prNotPendingHours": 12,
+  "prNotPendingHours": 24,
   "prTitle": "{{#if isPin}}Pin{{else}}{{#if isRollback}}Roll back{{else}}Update{{/if}}{{/if}} dependency {{depName}} to {{#if isRange}}{{newVersion}}{{else}}{{#if isMajor}}v{{newVersionMajor}}{{else}}v{{newVersion}}{{/if}}{{/if}}",
   "privateKey": null,
   "rebaseStalePrs": false,

test/workers/package/__snapshots__/index.spec.js.snap

@@ -139,7 +139,7 @@ Please make sure the following warnings are safe to ignore:
 
 This PR has been generated by [Renovate Bot](https://renovateapp.com).",
   "prCreation": "immediate",
-  "prNotPendingHours": 12,
+  "prNotPendingHours": 24,
   "prTitle": "{{#if isPin}}Pin{{else}}{{#if isRollback}}Roll back{{else}}Update{{/if}}{{/if}} dependency {{depName}} to {{#if isRange}}{{newVersion}}{{else}}{{#if isMajor}}v{{newVersionMajor}}{{else}}v{{newVersion}}{{/if}}{{/if}}",
   "rebaseStalePrs": true,
   "recreateClosed": true,

test/workers/repository/updates/__snapshots__/branchify.spec.js.snap

@@ -541,7 +541,7 @@ Please make sure the following warnings are safe to ignore:
 
 This PR has been generated by [Renovate Bot](https://renovateapp.com).",
   "prCreation": "immediate",
-  "prNotPendingHours": 12,
+  "prNotPendingHours": 24,
   "prTitle": "{{#if isPin}}Pin{{else}}{{#if isRollback}}Roll back{{else}}Update{{/if}}{{/if}} dependency {{depName}} to {{#if isRange}}{{newVersion}}{{else}}{{#if isMajor}}v{{newVersionMajor}}{{else}}v{{newVersion}}{{/if}}{{/if}}",
   "privateKey": null,
   "rebaseStalePrs": false,
@@ -1102,7 +1102,7 @@ Please make sure the following warnings are safe to ignore:
 
 This PR has been generated by [Renovate Bot](https://renovateapp.com).",
   "prCreation": "immediate",
-  "prNotPendingHours": 12,
+  "prNotPendingHours": 24,
   "prTitle": "{{#if isPin}}Pin{{else}}{{#if isRollback}}Roll back{{else}}Update{{/if}}{{/if}} dependency {{depName}} to {{#if isRange}}{{newVersion}}{{else}}{{#if isMajor}}v{{newVersionMajor}}{{else}}v{{newVersion}}{{/if}}{{/if}}",
   "privateKey": null,
   "rebaseStalePrs": false,
@@ -1669,7 +1669,7 @@ Please make sure the following warnings are safe to ignore:
 
 This PR has been generated by [Renovate Bot](https://renovateapp.com).",
   "prCreation": "immediate",
-  "prNotPendingHours": 12,
+  "prNotPendingHours": 24,
   "prTitle": "{{#if isPin}}Pin{{else}}{{#if isRollback}}Roll back{{else}}Update{{/if}}{{/if}} dependency {{depName}} to {{#if isRange}}{{newVersion}}{{else}}{{#if isMajor}}v{{newVersionMajor}}{{else}}v{{newVersion}}{{/if}}{{/if}}",
   "privateKey": null,
   "rebaseStalePrs": false,
@@ -2224,7 +2224,7 @@ Please make sure the following warnings are safe to ignore:
 
 This PR has been generated by [Renovate Bot](https://renovateapp.com).",
   "prCreation": "immediate",
-  "prNotPendingHours": 12,
+  "prNotPendingHours": 24,
   "prTitle": "{{#if isPin}}Pin{{else}}{{#if isRollback}}Roll back{{else}}Update{{/if}}{{/if}} dependency {{depName}} to {{#if isRange}}{{newVersion}}{{else}}{{#if isMajor}}v{{newVersionMajor}}{{else}}v{{newVersion}}{{/if}}{{/if}}",
   "privateKey": null,
   "rebaseStalePrs": false,
@@ -2774,7 +2774,7 @@ Please make sure the following warnings are safe to ignore:
 
 This PR has been generated by [Renovate Bot](https://renovateapp.com).",
   "prCreation": "immediate",
-  "prNotPendingHours": 12,
+  "prNotPendingHours": 24,
   "prTitle": "{{#if isPin}}Pin{{else}}{{#if isRollback}}Roll back{{else}}Update{{/if}}{{/if}} dependency {{depName}} to {{#if isRange}}{{newVersion}}{{else}}{{#if isMajor}}v{{newVersionMajor}}{{else}}v{{newVersion}}{{/if}}{{/if}}",
   "privateKey": null,
   "rebaseStalePrs": false,