Skip to content
Snippets Groups Projects
Unverified Commit 8d0c72af authored by Rhys Arkins's avatar Rhys Arkins Committed by GitHub
Browse files

fix(config): filter out invalid massaged packageRules (#16778)

Closes #16777
parent 2446f446
No related merge requests found
...@@ -46,6 +46,21 @@ describe('config/massage', () => { ...@@ -46,6 +46,21 @@ describe('config/massage', () => {
expect(res.packageRules).toHaveLength(3); expect(res.packageRules).toHaveLength(3);
}); });
it('filters packageRules with only match/exclude', () => {
const config: RenovateConfig = {
packageRules: [
{
matchBaseBranches: ['main'],
major: {
enabled: true,
},
},
],
};
const res = massage.massageConfig(config);
expect(res.packageRules).toHaveLength(1);
});
it('does not massage lockFileMaintenance', () => { it('does not massage lockFileMaintenance', () => {
const config: RenovateConfig = { const config: RenovateConfig = {
packageRules: [ packageRules: [
......
...@@ -40,7 +40,7 @@ export function massageConfig(config: RenovateConfig): RenovateConfig { ...@@ -40,7 +40,7 @@ export function massageConfig(config: RenovateConfig): RenovateConfig {
} }
} }
if (is.nonEmptyArray(massagedConfig.packageRules)) { if (is.nonEmptyArray(massagedConfig.packageRules)) {
const newRules: PackageRule[] = []; let newRules: PackageRule[] = [];
const updateTypes: UpdateType[] = [ const updateTypes: UpdateType[] = [
'major', 'major',
'minor', 'minor',
...@@ -74,6 +74,17 @@ export function massageConfig(config: RenovateConfig): RenovateConfig { ...@@ -74,6 +74,17 @@ export function massageConfig(config: RenovateConfig): RenovateConfig {
delete rule[updateType]; delete rule[updateType];
}); });
} }
newRules = newRules.filter((rule) => {
if (
Object.keys(rule).every(
(key) => key.startsWith('match') || key.startsWith('exclude')
)
) {
// Exclude rules which contain only match or exclude options
return false;
}
return true;
});
massagedConfig.packageRules = newRules; massagedConfig.packageRules = newRules;
} }
return massagedConfig; return massagedConfig;
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment